Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1096)

Issue 2392043002: Server push cancellation: add metrics to collect (Closed)

Created:
4 years, 2 months ago by Zhongyi Shi
Modified:
4 years, 2 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Server push cancellation: add metrics to collect * how many bytes has been pushed, * how many bytes has been pushed and unclaimed BUG=232040 Committed: https://crrev.com/92bd5b4ddf200bd34f55e77b1d835203627c8dc6 Cr-Commit-Position: refs/heads/master@{#425465}

Patch Set 1 #

Total comments: 2

Patch Set 2 : collect metrics when streams are closed #

Total comments: 2

Patch Set 3 : TODO: add networktransaction_unittests #

Total comments: 4

Patch Set 4 : address asvitkine's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -0 lines) Patch
M net/quic/chromium/quic_chromium_client_session.h View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M net/quic/chromium/quic_chromium_client_session.cc View 1 2 3 5 chunks +18 lines, -0 lines 0 comments Download
M net/quic/core/quic_client_promised_info.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/quic_client_session_base.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/core/quic_client_session_base.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 28 (11 generated)
Zhongyi Shi
4 years, 2 months ago (2016-10-04 18:16:42 UTC) #2
Buck
https://codereview.chromium.org/2392043002/diff/1/net/quic/chromium/quic_chromium_client_session.cc File net/quic/chromium/quic_chromium_client_session.cc (right): https://codereview.chromium.org/2392043002/diff/1/net/quic/chromium/quic_chromium_client_session.cc#newcode1412 net/quic/chromium/quic_chromium_client_session.cc:1412: bytes_pushed_count_ += content_length; Instead of looking to headers, would ...
4 years, 2 months ago (2016-10-04 21:06:04 UTC) #3
Ryan Hamilton
https://codereview.chromium.org/2392043002/diff/1/net/quic/chromium/quic_chromium_client_session.cc File net/quic/chromium/quic_chromium_client_session.cc (right): https://codereview.chromium.org/2392043002/diff/1/net/quic/chromium/quic_chromium_client_session.cc#newcode1412 net/quic/chromium/quic_chromium_client_session.cc:1412: bytes_pushed_count_ += content_length; I'm not sure that checking content-length ...
4 years, 2 months ago (2016-10-05 00:24:09 UTC) #4
Zhongyi Shi
I agreed that the stream_bytes_written is more close to what we want to measure. In ...
4 years, 2 months ago (2016-10-05 18:11:43 UTC) #5
Ryan Hamilton
On 2016/10/05 18:11:43, Zhongyi Shi wrote: > I agreed that the stream_bytes_written is more close ...
4 years, 2 months ago (2016-10-06 02:43:02 UTC) #6
Zhongyi Shi
On 2016/10/06 02:43:02, Ryan Hamilton wrote: > On 2016/10/05 18:11:43, Zhongyi Shi wrote: > > ...
4 years, 2 months ago (2016-10-06 21:06:36 UTC) #9
Zhongyi Shi
Change to collect metrics when stream is closed. ptal!
4 years, 2 months ago (2016-10-06 21:08:27 UTC) #10
Buck
https://codereview.chromium.org/2392043002/diff/20001/net/quic/chromium/quic_chromium_client_session.cc File net/quic/chromium/quic_chromium_client_session.cc (right): https://codereview.chromium.org/2392043002/diff/20001/net/quic/chromium/quic_chromium_client_session.cc#newcode285 net/quic/chromium/quic_chromium_client_session.cc:285: I don't think this covers everything. I think you ...
4 years, 2 months ago (2016-10-06 21:29:12 UTC) #11
Zhongyi Shi
Changed to collect data for those streams that are explicitly timed out. I will add ...
4 years, 2 months ago (2016-10-13 21:06:42 UTC) #15
Buck
lgtm. About tests, I see that there are tests for histograms using base::HistogramTester in quic_network_transaction_unittest.cc. ...
4 years, 2 months ago (2016-10-13 23:19:03 UTC) #16
Ryan Hamilton
lgtm
4 years, 2 months ago (2016-10-13 23:38:26 UTC) #17
Zhongyi Shi
Alexei, ptal!
4 years, 2 months ago (2016-10-14 17:08:38 UTC) #19
Alexei Svitkine (slow)
lgtm % comments https://codereview.chromium.org/2392043002/diff/40001/net/quic/chromium/quic_chromium_client_session.cc File net/quic/chromium/quic_chromium_client_session.cc (right): https://codereview.chromium.org/2392043002/diff/40001/net/quic/chromium/quic_chromium_client_session.cc#newcode323 net/quic/chromium/quic_chromium_client_session.cc:323: DCHECK(bytes_pushed_and_unclaimed_count_ <= bytes_pushed_count_); Nit: Can this ...
4 years, 2 months ago (2016-10-14 17:12:17 UTC) #20
Zhongyi Shi
I am going to land this cl now, and will add unittests in a separate ...
4 years, 2 months ago (2016-10-14 19:31:17 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2392043002/60001
4 years, 2 months ago (2016-10-14 19:32:10 UTC) #24
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 2 months ago (2016-10-14 21:19:08 UTC) #26
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 21:21:42 UTC) #28
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/92bd5b4ddf200bd34f55e77b1d835203627c8dc6
Cr-Commit-Position: refs/heads/master@{#425465}

Powered by Google App Engine
This is Rietveld 408576698