Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Unified Diff: third_party/WebKit/Source/platform/fonts/SimpleFontData.h

Issue 2392033002: Correcting text baseline for tiny fonts (Closed)
Patch Set: Rebaseline. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/fonts/SimpleFontData.h
diff --git a/third_party/WebKit/Source/platform/fonts/SimpleFontData.h b/third_party/WebKit/Source/platform/fonts/SimpleFontData.h
index 64ce4d18ea278d08b5f1117bdbcf521f92d8ec57..ebdfc5cd55bb0fa03763ea41f2d80c6dca2baf69 100644
--- a/third_party/WebKit/Source/platform/fonts/SimpleFontData.h
+++ b/third_party/WebKit/Source/platform/fonts/SimpleFontData.h
@@ -60,9 +60,11 @@ class PLATFORM_EXPORT SimpleFontData : public FontData {
static PassRefPtr<SimpleFontData> create(
const FontPlatformData& platformData,
PassRefPtr<CustomFontData> customData = nullptr,
- bool isTextOrientationFallback = false) {
+ bool isTextOrientationFallback = false,
+ bool subpixelAscentDescent = false) {
return adoptRef(new SimpleFontData(platformData, std::move(customData),
- isTextOrientationFallback));
+ isTextOrientationFallback,
+ subpixelAscentDescent));
}
~SimpleFontData() override;
@@ -161,7 +163,8 @@ class PLATFORM_EXPORT SimpleFontData : public FontData {
protected:
SimpleFontData(const FontPlatformData&,
PassRefPtr<CustomFontData> customData,
- bool isTextOrientationFallback = false);
+ bool isTextOrientationFallback = false,
+ bool subpixelAscentDescent = false);
SimpleFontData(PassRefPtr<CustomFontData> customData,
float fontSize,
@@ -169,7 +172,7 @@ class PLATFORM_EXPORT SimpleFontData : public FontData {
bool syntheticItalic);
private:
- void platformInit();
+ void platformInit(bool subpixelAscentDescent);
void platformGlyphInit();
PassRefPtr<SimpleFontData> createScaledFontData(const FontDescription&,

Powered by Google App Engine
This is Rietveld 408576698