Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1162)

Unified Diff: third_party/WebKit/Source/platform/fonts/FontDataCache.cpp

Issue 2392033002: Correcting text baseline for tiny fonts (Closed)
Patch Set: Rebaseline. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/fonts/FontDataCache.cpp
diff --git a/third_party/WebKit/Source/platform/fonts/FontDataCache.cpp b/third_party/WebKit/Source/platform/fonts/FontDataCache.cpp
index 2e2c56f54b37ec0ea611e285adffe33c771e7e60..98cd954c34d39d357480a86121442bf67772fb89 100644
--- a/third_party/WebKit/Source/platform/fonts/FontDataCache.cpp
+++ b/third_party/WebKit/Source/platform/fonts/FontDataCache.cpp
@@ -46,7 +46,8 @@ const unsigned cTargetInactiveFontData = 200;
PassRefPtr<SimpleFontData> FontDataCache::get(
const FontPlatformData* platformData,
- ShouldRetain shouldRetain) {
+ ShouldRetain shouldRetain,
+ bool subpixelAscentDescent) {
if (!platformData)
return nullptr;
@@ -62,7 +63,9 @@ PassRefPtr<SimpleFontData> FontDataCache::get(
Cache::iterator result = m_cache.find(platformData);
if (result == m_cache.end()) {
std::pair<RefPtr<SimpleFontData>, unsigned> newValue(
- SimpleFontData::create(*platformData), shouldRetain == Retain ? 1 : 0);
+ SimpleFontData::create(*platformData, nullptr, false,
+ subpixelAscentDescent),
+ shouldRetain == Retain ? 1 : 0);
// The new SimpleFontData takes a copy of the incoming FontPlatformData
// object. The incoming key may be temporary. So, for cache storage, take
// the address of the newly created FontPlatformData that is copied an owned

Powered by Google App Engine
This is Rietveld 408576698