third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.h - Issue 2392033002: Correcting text baseline for tiny fonts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.h

Issue 2392033002: Correcting text baseline for tiny fonts (Closed)

Patch Set: Rebaseline. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/canvas/canvas-text-baseline-tiny-fonts.html ('k') | third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp » ('j') | third_party/WebKit/Source/platform/fonts/SimpleFontData.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.h

diff --git a/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.h b/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.h

index 195990287f32132eae54c3c30f3b360ff7906dc2..b5680fc25396643242adfb74f9ac1ed8cfb741fe 100644

--- a/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.h

+++ b/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.h

@@ -221,7 +221,7 @@ class MODULES_EXPORT CanvasRenderingContext2D final

double* maxWidth = nullptr);

const Font& accessFont();

- int getFontBaseline(const FontMetrics&) const;

+ float getFontBaseline(const FontMetrics&) const;

void drawFocusIfNeededInternal(const Path&, Element*);

bool focusRingCallIsValid(const Path&, Element*);