Handlify CodeCache.

Handlify CodeCache.

R=yangguo@chromium.org
BUG=

Committed: https://code.google.com/p/v8/source/detail?r=20801

[Dmitry Lomov (no reviews), 2014-04-15 14:26:27]

PTAL

[Yang, 2014-04-15 14:33:08]

LGTM. Adding Igor to CC to prevent him from redoing this.

https://codereview.chromium.org/239203003/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/239203003/diff/1/src/objects.cc#newcode7526
src/objects.cc:7526: Handle<Object> CodeCache::Update(
I think this can return void, since we don't need a MaybeObject to signal
allocation failure anymore.

https://codereview.chromium.org/239203003/diff/1/src/objects.cc#newcode7547
src/objects.cc:7547: Handle<Object> CodeCache::UpdateDefaultCache(
Return void?

https://codereview.chromium.org/239203003/diff/1/src/objects.cc#newcode7607
src/objects.cc:7607: Handle<Object> CodeCache::UpdateNormalTypeCache(
Return void?

https://codereview.chromium.org/239203003/diff/1/src/objects.cc#newcode7780
src/objects.cc:7780: Handle<CodeCacheHashTable> CodeCacheHashTable::Put(
Return void?

https://codereview.chromium.org/239203003/diff/1/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/239203003/diff/1/src/objects.h#newcode8347
src/objects.h:8347: Handle<CodeCacheHashTable> table,
please put each argument on its own line.

[Dmitry Lomov (no reviews), 2014-04-15 14:49:34]

feedback addressed, landing

https://codereview.chromium.org/239203003/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/239203003/diff/1/src/objects.cc#newcode7526
src/objects.cc:7526: Handle<Object> CodeCache::Update(
On 2014/04/15 14:33:09, Yang wrote:
> I think this can return void, since we don't need a MaybeObject to signal
> allocation failure anymore.

Done.

https://codereview.chromium.org/239203003/diff/1/src/objects.cc#newcode7547
src/objects.cc:7547: Handle<Object> CodeCache::UpdateDefaultCache(
On 2014/04/15 14:33:09, Yang wrote:
> Return void?

Done.

https://codereview.chromium.org/239203003/diff/1/src/objects.cc#newcode7607
src/objects.cc:7607: Handle<Object> CodeCache::UpdateNormalTypeCache(
On 2014/04/15 14:33:09, Yang wrote:
> Return void?

Done.

https://codereview.chromium.org/239203003/diff/1/src/objects.cc#newcode7780
src/objects.cc:7780: Handle<CodeCacheHashTable> CodeCacheHashTable::Put(
On 2014/04/15 14:33:09, Yang wrote:
> Return void?
No, it returns a new object.

https://codereview.chromium.org/239203003/diff/1/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/239203003/diff/1/src/objects.h#newcode8347
src/objects.h:8347: Handle<CodeCacheHashTable> table,
On 2014/04/15 14:33:09, Yang wrote:
> please put each argument on its own line.

Done.

[ulan, 2014-04-15 15:17:19]

https://codereview.chromium.org/239203003/diff/20001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/239203003/diff/20001/src/objects.cc#newcode7280
src/objects.cc:7280: Isolate* isolate = map->GetIsolate();
Note that map->code_cache is cleared on GC.

Could you add HandleScope here to bound the life-time code_cache?

[Dmitry Lomov (no reviews), 2014-04-16 12:11:04]

Committed patchset #2 manually as r20801 (presubmit successful).

[Dmitry Lomov (no reviews), 2014-04-16 12:12:24]

On 2014/04/15 15:17:19, ulan wrote:
> https://codereview.chromium.org/239203003/diff/20001/src/objects.cc
> File src/objects.cc (right):
> 
>
https://codereview.chromium.org/239203003/diff/20001/src/objects.cc#newcode7280
> src/objects.cc:7280: Isolate* isolate = map->GetIsolate();
> Note that map->code_cache is cleared on GC.
> 
> Could you add HandleScope here to bound the life-time code_cache?

Sorry, missed your comment, will do a separate CL for that.