Issue 239203002: Move CopyReplaceDescriptors to private

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 239203002: Move CopyReplaceDescriptors to private (Closed)

Created:
6 years, 8 months ago by Toon Verwaest

Modified:
6 years, 8 months ago

Reviewers:
Igor Sheludko

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Move CopyReplaceDescriptors to private BUG= R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20793

Patch Set 3 : #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -32 lines)			Patch
	M	src/objects.h	View	1	3 chunks	+8 lines, -11 lines	0 comments	Download
	M	src/objects.cc	View	1 2	5 chunks	+20 lines, -21 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Igor Sheludko

lgtm with a nit: https://codereview.chromium.org/239203002/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/239203002/diff/1/src/objects.cc#newcode6950 src/objects.cc:6950: Handle<Name> name, While we are ...

6 years, 8 months ago (2014-04-16 10:26:20 UTC) #2

Toon Verwaest

Addressed comments https://codereview.chromium.org/239203002/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/239203002/diff/1/src/objects.cc#newcode6950 src/objects.cc:6950: Handle<Name> name, On 2014/04/16 10:26:21, Igor Sheludko ...

6 years, 8 months ago (2014-04-16 11:16:47 UTC) #3

Toon Verwaest

6 years, 8 months ago (2014-04-16 11:25:44 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r20793 (presubmit successful).

Expand Messages | Collapse Messages

Issue 239203002: Move CopyReplaceDescriptors to private (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages