Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(659)

Issue 2392023002: VrShell: Restore smooth reticle positioning in the user FOV. (Closed)

Created:
4 years, 2 months ago by cjgrant
Modified:
4 years, 2 months ago
Reviewers:
mthiesse, bshe
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

VrShell: Restore smooth reticle positioning in the user FOV. BUG=41413 Committed: https://crrev.com/9976d47e56a3694e3351d7a0c3bb2d26a1c81551 Cr-Commit-Position: refs/heads/master@{#422889}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix comment nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -11 lines) Patch
M chrome/browser/android/vr_shell/vr_shell.cc View 1 5 chunks +24 lines, -11 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
cjgrant
4 years, 2 months ago (2016-10-04 16:06:45 UTC) #3
mthiesse
lgtm
4 years, 2 months ago (2016-10-04 17:09:32 UTC) #4
bshe
lgtm with nits https://codereview.chromium.org/2392023002/diff/1/chrome/browser/android/vr_shell/vr_shell.cc File chrome/browser/android/vr_shell/vr_shell.cc (right): https://codereview.chromium.org/2392023002/diff/1/chrome/browser/android/vr_shell/vr_shell.cc#newcode257 chrome/browser/android/vr_shell/vr_shell.cc:257: // in other directions. Note that ...
4 years, 2 months ago (2016-10-04 18:56:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2392023002/20001
4 years, 2 months ago (2016-10-04 19:33:16 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-04 19:44:10 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 19:47:14 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9976d47e56a3694e3351d7a0c3bb2d26a1c81551
Cr-Commit-Position: refs/heads/master@{#422889}

Powered by Google App Engine
This is Rietveld 408576698