Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Unified Diff: remoting/android/java/src/org/chromium/chromoting/DesktopView.java

Issue 2391993004: [Remoting Android] Hide soft keyboard button when physical keyboard is connected (Closed)
Patch Set: Only hide the button for QWERTY keyboard Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/android/java/src/org/chromium/chromoting/DesktopView.java
diff --git a/remoting/android/java/src/org/chromium/chromoting/DesktopView.java b/remoting/android/java/src/org/chromium/chromoting/DesktopView.java
index 7a4e3a3a04751ef3bfa71d1d6dedd82e26b2fccb..ac324e9ab0eb594f54d16c8a9d57b8c935388d82 100644
--- a/remoting/android/java/src/org/chromium/chromoting/DesktopView.java
+++ b/remoting/android/java/src/org/chromium/chromoting/DesktopView.java
@@ -11,7 +11,6 @@ import android.view.MotionEvent;
import android.view.SurfaceView;
import android.view.inputmethod.EditorInfo;
import android.view.inputmethod.InputConnection;
-import android.view.inputmethod.InputMethodManager;
import org.chromium.chromoting.jni.Client;
@@ -58,19 +57,6 @@ public final class DesktopView extends SurfaceView {
mInputHandler.detachEventListeners();
}
- // TODO(yuweih): move showActionBar and showKeyboard out of this class.
- /** Shows the action bar. */
- public final void showActionBar() {
- mDesktop.showSystemUi();
- }
-
- /** Shows the software keyboard. */
- public final void showKeyboard() {
- InputMethodManager inputManager =
- (InputMethodManager) getContext().getSystemService(Context.INPUT_METHOD_SERVICE);
- inputManager.showSoftInput(this, 0);
- }
-
/** An {@link Event} which is triggered when user touches the screen. */
public final Event<TouchEventParameter> onTouch() {
return mOnTouch;

Powered by Google App Engine
This is Rietveld 408576698