[Remoting Android] Hide soft keyboard button when physical keyboard is connected

remoting/android/java/src/org/chromium/chromoting/Desktop.java

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chromoting;
 
 import android.annotation.SuppressLint;
+import android.content.res.Configuration;
 import android.os.Build;
 import android.os.Bundle;
 import android.os.Handler;
 import android.support.v7.app.ActionBar.OnMenuVisibilityListener;
 import android.support.v7.app.AppCompatActivity;
 import android.support.v7.widget.Toolbar;
 import android.view.KeyEvent;
 import android.view.Menu;
 import android.view.MenuItem;
 import android.view.MotionEvent;
 import android.view.View;
 import android.view.View.OnLayoutChangeListener;
 import android.view.View.OnTouchListener;
 import android.view.inputmethod.InputMethodManager;
 
 import org.chromium.chromoting.help.HelpContext;
 import org.chromium.chromoting.help.HelpSingleton;
 import org.chromium.chromoting.jni.Client;
+import org.chromium.ui.UiUtils;
 
 import java.util.List;
 
 /**
  * A simple screen that does nothing except display a DesktopView and notify it of rotations.
  */
 public class Desktop
         extends AppCompatActivity implements View.OnSystemUiVisibilityChangeListener,
                                              CapabilityManager.CapabilitiesChangedListener {
     /** Used to set/store the selected input mode. */
@@ skipping 35 matching lines @@
 
     /** Tracks the current input mode (e.g. trackpad/touch). */
     private InputMode mInputMode = InputMode.UNKNOWN;
 
     /** Indicates whether the remote host supports touch injection. */
     private CapabilityManager.HostCapability mHostTouchCapability =
             CapabilityManager.HostCapability.UNKNOWN;
 
     private DesktopView mRemoteHostDesktop;
 
+    private boolean mHasPhysicalKeyboard;

[joedow, 2016/10/05 22:50:59]

Can you add a comment on how you detect a physical keyboard and any gotchas you
can think of for future engineers?  We are trying to deduce whether a keyboard
exists or not and that might prove wrong for a subset of Android hardware.

[Yuwei, 2016/10/06 00:26:50]

Done.

+
     /** Called when the activity is first created. */
     @Override
     public void onCreate(Bundle savedInstanceState) {
         super.onCreate(savedInstanceState);
         setContentView(R.layout.desktop);
 
         mClient = Client.getInstance();
         mInjector = new InputEventSender(mClient);
 
         Preconditions.notNull(mClient);
@@ skipping 124 matching lines @@
                     }
                 }
             });
         }
 
         ChromotingUtil.tintMenuIcons(this, menu);
 
         // Wait to set the input mode until after the default tinting has been applied.
         setInputMode(mInputMode);
 
+        // Keyboard state must be set after the options menu is created since it needs to alter the
+        // visibility of the keyboard button.

[joedow, 2016/10/05 22:50:59]

Shorten this to one line if possible:
"Keyboard state must be set after the keyboard icon has been added to the menu."

[Yuwei, 2016/10/06 00:26:50]

Done.

+        setKeyboardState(getResources().getConfiguration().keyboard);
+
         return super.onCreateOptionsMenu(menu);
     }
 
+    @Override
+    public void onConfigurationChanged(Configuration config) {
+        super.onConfigurationChanged(config);
+        setKeyboardState(config.keyboard);
+    }
+
+    private void setKeyboardState(int keyboardState) {
+        mHasPhysicalKeyboard = (keyboardState & Configuration.KEYBOARD_NOKEYS) == 0;

[Yuwei, 2016/10/06 00:26:50]

Oops. Looks like keyboardState is just an integer enum, not bit flags...

+        mToolbar.getMenu().findItem(R.id.actionbar_keyboard).setVisible(!mHasPhysicalKeyboard);
+    }
+
     public Event<SystemUiVisibilityChangedEventParameter> onSystemUiVisibilityChanged() {
         return mOnSystemUiVisibilityChanged;
     }
 
     public Event<InputModeChangedEventParameter> onInputModeChanged() {
         return mOnInputModeChanged;
     }
 
     private InputMode getInitialInputModeValue() {
         // Load the previously-selected input mode from Preferences.
@@ skipping 139 matching lines @@
     private static int getLayoutFlags() {
         int flags = 0;
         if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.KITKAT) {
             flags |= View.SYSTEM_UI_FLAG_LAYOUT_FULLSCREEN;
             flags |= View.SYSTEM_UI_FLAG_LAYOUT_HIDE_NAVIGATION;
             flags |= View.SYSTEM_UI_FLAG_LAYOUT_STABLE;
         }
         return flags;
     }
 
+    /**
+     * Shows the soft keyboard on the remote desktop view. Do nothing if a physical keyboard is
+     * present.

[joedow, 2016/10/05 22:50:59]

nit: Shorten to one line if possible...

[Yuwei, 2016/10/06 00:26:50]

Done.

+     */
+    public void showKeyboard() {
+        if (!mHasPhysicalKeyboard) {
+            UiUtils.showKeyboard(mRemoteHostDesktop);
+        }
+    }
+
     public void showSystemUi() {
         // Request exit from any fullscreen mode. The action-bar controls will be shown in response
         // to the SystemUiVisibility notification. The visibility of the action-bar should be tied
         // to the fullscreen state of the system, so there's no need to explicitly show it here.
         int flags = View.SYSTEM_UI_FLAG_VISIBLE | getLayoutFlags();
         getWindow().getDecorView().setSystemUiVisibility(flags);
 
         // The OS will not call onSystemUiVisibilityChange() if the soft keyboard is visible which
         // means our ActionBar will not be shown if this function is called in that scenario.
         if (mSoftInputVisible) {
@@ skipping 143 matching lines @@
     @Override
     public boolean dispatchKeyEvent(KeyEvent event) {
         if (event.getKeyCode() == KeyEvent.KEYCODE_BACK) {
             mClient.destroy();
             return super.dispatchKeyEvent(event);
         }
 
         return mInjector.sendKeyEvent(event);
     }
 }