Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 2391993002: [Field trial] Update the testing config for AutofillCreditCardSigninPromo (Closed)

Created:
4 years, 2 months ago by Mathieu
Modified:
4 years, 2 months ago
Reviewers:
rkaplow
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Field trial] Update the testing config for AutofillCreditCardSigninPromo BUG=None Committed: https://crrev.com/3280efd72b258e79267033efd80c7fd0379c4c59 Cr-Commit-Position: refs/heads/master@{#422852}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Only one experiment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M testing/variations/fieldtrial_testing_config.json View 1 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Mathieu
Hi Rob, take a look :)
4 years, 2 months ago (2016-10-04 15:26:59 UTC) #2
rkaplow
https://codereview.chromium.org/2391993002/diff/1/testing/variations/fieldtrial_testing_config.json File testing/variations/fieldtrial_testing_config.json (right): https://codereview.chromium.org/2391993002/diff/1/testing/variations/fieldtrial_testing_config.json#newcode98 testing/variations/fieldtrial_testing_config.json:98: "name": "EnabledThree", we only support a single experiment here. ...
4 years, 2 months ago (2016-10-04 16:53:46 UTC) #3
Mathieu
PTAL https://codereview.chromium.org/2391993002/diff/1/testing/variations/fieldtrial_testing_config.json File testing/variations/fieldtrial_testing_config.json (right): https://codereview.chromium.org/2391993002/diff/1/testing/variations/fieldtrial_testing_config.json#newcode98 testing/variations/fieldtrial_testing_config.json:98: "name": "EnabledThree", On 2016/10/04 16:53:45, rkaplow wrote: > ...
4 years, 2 months ago (2016-10-04 16:54:57 UTC) #4
rkaplow
lgtm
4 years, 2 months ago (2016-10-04 16:55:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2391993002/20001
4 years, 2 months ago (2016-10-04 16:56:41 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-04 17:46:02 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 17:48:24 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3280efd72b258e79267033efd80c7fd0379c4c59
Cr-Commit-Position: refs/heads/master@{#422852}

Powered by Google App Engine
This is Rietveld 408576698