arc: bluetooth: Send update to Android when got DeviceChanged event

arc: bluetooth: Send update to Android when got DeviceChanged event

Currently we only send device properties and advertising data to
Android only when we first found a new device. We should also
update Android when we got DeviceChanged event.

Also refactor the code to
- Add new SendDevice() for common code related to this.
- Filter invalid data out from data that will send to Android.

BUG=653310, b:31916649
TEST=nRF Connect app in minnie correctly show rssi graph

Committed: https://crrev.com/d3ea5c2b19cc8e59566037206cff597f685dea6e
Cr-Commit-Position: refs/heads/master@{#423726}

[puthik_chromium, 2016-10-05 00:09:19]

puthik@chromium.org changed reviewers:
+ lhchavez@chromium.org, steel@chromium.org

[puthik_chromium, 2016-10-05 00:09:19]

PTAL

[puthik_chromium, 2016-10-05 23:21:57]

Description was changed from

==========
arc: bluetooth: Send update to Android when got DeviceChanged event

Currently we only send device properties and advertising data to
Android only when we first found a new device. We should also
update Android when we got DeviceChanged event.

Also refactor the code to
- Add new SendDeviceData() for common code related to this.
- Filter invalid data out from data that will send to Android.

BUG=b:31916649
TEST=nRF Connect app in minnie correctly show rssi graph
==========

to

==========
arc: bluetooth: Send update to Android when got DeviceChanged event

Currently we only send device properties and advertising data to
Android only when we first found a new device. We should also
update Android when we got DeviceChanged event.

Also refactor the code to
- Add new SendDeviceData() for common code related to this.
- Filter invalid data out from data that will send to Android.

BUG=653310,b:31916649
TEST=nRF Connect app in minnie correctly show rssi graph
==========

[Luis Héctor Chávez, 2016-10-06 16:51:01]

https://codereview.chromium.org/2391973003/diff/1/components/arc/bluetooth/ar...
File components/arc/bluetooth/arc_bluetooth_bridge.cc (right):

https://codereview.chromium.org/2391973003/diff/1/components/arc/bluetooth/ar...
components/arc/bluetooth/arc_bluetooth_bridge.cc:314: void
ArcBluetoothBridge::SendDeviceData(const BluetoothDevice* device) const {
Maybe SendDevicePropertiesAndAdvData? SendDeviceInformation?
SendDeviceProperties?

[puthik_chromium, 2016-10-06 18:29:30]

https://codereview.chromium.org/2391973003/diff/1/components/arc/bluetooth/ar...
File components/arc/bluetooth/arc_bluetooth_bridge.cc (right):

https://codereview.chromium.org/2391973003/diff/1/components/arc/bluetooth/ar...
components/arc/bluetooth/arc_bluetooth_bridge.cc:314: void
ArcBluetoothBridge::SendDeviceData(const BluetoothDevice* device) const {
On 2016/10/06 16:51:01, Luis Héctor Chávez wrote:
> Maybe SendDevicePropertiesAndAdvData? SendDeviceInformation?
> SendDeviceProperties?
SendDeviceInformation

[Rahul Chaturvedi, 2016-10-06 19:18:43]

lgtm

https://codereview.chromium.org/2391973003/diff/20001/components/arc/bluetoot...
File components/arc/bluetooth/arc_bluetooth_bridge.cc (right):

https://codereview.chromium.org/2391973003/diff/20001/components/arc/bluetoot...
components/arc/bluetooth/arc_bluetooth_bridge.cc:330: base::Optional<int8_t>
rssi = device->GetInquiryRSSI();
Optional nit: SendDevice seems more accurate, since we're actually sending over
everything that defines what a device really is.

[Luis Héctor Chávez, 2016-10-06 19:22:17]

lgtm, but please update the commit message once you settle on a name.

[puthik_chromium, 2016-10-06 19:33:12]

Description was changed from

==========
arc: bluetooth: Send update to Android when got DeviceChanged event

Currently we only send device properties and advertising data to
Android only when we first found a new device. We should also
update Android when we got DeviceChanged event.

Also refactor the code to
- Add new SendDeviceData() for common code related to this.
- Filter invalid data out from data that will send to Android.

BUG=653310,b:31916649
TEST=nRF Connect app in minnie correctly show rssi graph
==========

to

==========
arc: bluetooth: Send update to Android when got DeviceChanged event

Currently we only send device properties and advertising data to
Android only when we first found a new device. We should also
update Android when we got DeviceChanged event.

Also refactor the code to
- Add new SendDevice() for common code related to this.
- Filter invalid data out from data that will send to Android.

BUG=653310,b:31916649
TEST=nRF Connect app in minnie correctly show rssi graph
==========

[puthik_chromium, 2016-10-06 19:36:51]

https://codereview.chromium.org/2391973003/diff/20001/components/arc/bluetoot...
File components/arc/bluetooth/arc_bluetooth_bridge.cc (right):

https://codereview.chromium.org/2391973003/diff/20001/components/arc/bluetoot...
components/arc/bluetooth/arc_bluetooth_bridge.cc:330: base::Optional<int8_t>
rssi = device->GetInquiryRSSI();
On 2016/10/06 19:18:43, Rahul Chaturvedi wrote:
> Optional nit: SendDevice seems more accurate, since we're actually sending
over
> everything that defines what a device really is.

Done.

[puthik_chromium, 2016-10-06 19:36:58]

The CQ bit was checked by puthik@chromium.org

[puthik_chromium, 2016-10-06 19:36:58]

The patchset sent to the CQ was uploaded after l-g-t-m from steel@chromium.org,
lhchavez@chromium.org
Link to the patchset: https://codereview.chromium.org/2391973003/#ps40001
(title: "Use SendDevice()")

[commit-bot: I haz the power, 2016-10-06 19:37:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[puthik_chromium, 2016-10-06 20:46:46]

The CQ bit was unchecked by puthik@chromium.org

[puthik_chromium, 2016-10-06 20:54:02]

The CQ bit was checked by puthik@chromium.org

[puthik_chromium, 2016-10-06 20:54:03]

The patchset sent to the CQ was uploaded after l-g-t-m from steel@chromium.org,
lhchavez@chromium.org
Link to the patchset: https://codereview.chromium.org/2391973003/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2016-10-06 20:54:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 21:57:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 21:57:54]

Failed to apply patch for components/arc/bluetooth/arc_bluetooth_bridge.h:
While running git apply --index -3 -p1;
  error: patch failed: components/arc/bluetooth/arc_bluetooth_bridge.h:380
  Falling back to three-way merge...
  Applied patch to 'components/arc/bluetooth/arc_bluetooth_bridge.h' with
conflicts.
  U components/arc/bluetooth/arc_bluetooth_bridge.h

Patch:       components/arc/bluetooth/arc_bluetooth_bridge.h
Index: components/arc/bluetooth/arc_bluetooth_bridge.h
diff --git a/components/arc/bluetooth/arc_bluetooth_bridge.h
b/components/arc/bluetooth/arc_bluetooth_bridge.h
index
c0ad8ffdb71f3ffdafd6350fc3e94b6afef2942b..5affe9fa3522641f1cc86b6f9c57e46b39882634
100644
--- a/components/arc/bluetooth/arc_bluetooth_bridge.h
+++ b/components/arc/bluetooth/arc_bluetooth_bridge.h
@@ -321,11 +321,11 @@ class ArcBluetoothBridge
  private:
   mojo::Array<mojom::BluetoothPropertyPtr> GetDeviceProperties(
       mojom::BluetoothPropertyType type,
-      device::BluetoothDevice* device) const;
+      const device::BluetoothDevice* device) const;
   mojo::Array<mojom::BluetoothPropertyPtr> GetAdapterProperties(
       mojom::BluetoothPropertyType type) const;
   mojo::Array<mojom::BluetoothAdvertisingDataPtr> GetAdvertisingData(
-      device::BluetoothDevice* device) const;
+      const device::BluetoothDevice* device) const;
 
   void SendCachedDevicesFound() const;
 
@@ -380,6 +380,8 @@ class ArcBluetoothBridge
   void OnSetAdapterProperty(mojom::BluetoothStatus success,
                             mojom::BluetoothPropertyPtr property);
 
+  void SendDevice(const device::BluetoothDevice* device) const;
+
   bool CalledOnValidThread();
 
   mojo::Binding<mojom::BluetoothHost> binding_;

[puthik_chromium, 2016-10-06 22:06:14]

The CQ bit was checked by puthik@chromium.org

[puthik_chromium, 2016-10-06 22:06:15]

The patchset sent to the CQ was uploaded after l-g-t-m from steel@chromium.org,
lhchavez@chromium.org
Link to the patchset: https://codereview.chromium.org/2391973003/#ps80001
(title: "rebase again")

[commit-bot: I haz the power, 2016-10-06 22:06:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 23:19:40]

Description was changed from

==========
arc: bluetooth: Send update to Android when got DeviceChanged event

Currently we only send device properties and advertising data to
Android only when we first found a new device. We should also
update Android when we got DeviceChanged event.

Also refactor the code to
- Add new SendDevice() for common code related to this.
- Filter invalid data out from data that will send to Android.

BUG=653310,b:31916649
TEST=nRF Connect app in minnie correctly show rssi graph
==========

to

==========
arc: bluetooth: Send update to Android when got DeviceChanged event

Currently we only send device properties and advertising data to
Android only when we first found a new device. We should also
update Android when we got DeviceChanged event.

Also refactor the code to
- Add new SendDevice() for common code related to this.
- Filter invalid data out from data that will send to Android.

BUG=653310,b:31916649
TEST=nRF Connect app in minnie correctly show rssi graph
==========

[commit-bot: I haz the power, 2016-10-06 23:19:41]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-10-06 23:22:05]

Description was changed from

==========
arc: bluetooth: Send update to Android when got DeviceChanged event

Currently we only send device properties and advertising data to
Android only when we first found a new device. We should also
update Android when we got DeviceChanged event.

Also refactor the code to
- Add new SendDevice() for common code related to this.
- Filter invalid data out from data that will send to Android.

BUG=653310,b:31916649
TEST=nRF Connect app in minnie correctly show rssi graph
==========

to

==========
arc: bluetooth: Send update to Android when got DeviceChanged event

Currently we only send device properties and advertising data to
Android only when we first found a new device. We should also
update Android when we got DeviceChanged event.

Also refactor the code to
- Add new SendDevice() for common code related to this.
- Filter invalid data out from data that will send to Android.

BUG=653310,b:31916649
TEST=nRF Connect app in minnie correctly show rssi graph

Committed: https://crrev.com/d3ea5c2b19cc8e59566037206cff597f685dea6e
Cr-Commit-Position: refs/heads/master@{#423726}
==========

[commit-bot: I haz the power, 2016-10-06 23:22:07]

Patchset 5 (id:??) landed as
https://crrev.com/d3ea5c2b19cc8e59566037206cff597f685dea6e
Cr-Commit-Position: refs/heads/master@{#423726}