Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 2391973002: Revert of Prune createVisibleSelectionDeprecated from SelectionAdjuster (Closed)

Created:
4 years, 2 months ago by Xiaocheng
Modified:
4 years, 2 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Prune createVisibleSelectionDeprecated from SelectionAdjuster (patchset #1 id:1 of https://codereview.chromium.org/2389653002/ ) Reason for revert: Suspected of causing crbug.com/652301 Original issue's description: > Prune createVisibleSelectionDeprecated from SelectionAdjuster > > BUG=651373 > > Committed: https://crrev.com/1301c7b47926fa0d435c2f396a6aeba2a4d179c1 > Cr-Commit-Position: refs/heads/master@{#422380} TBR=yosin@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=651373 Committed: https://crrev.com/189778ba4d34566e1a237c4c21262a46c698f14c Cr-Commit-Position: refs/heads/master@{#422756}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M third_party/WebKit/Source/core/editing/FrameSelection.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/SelectionAdjuster.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Xiaocheng
Created Revert of Prune createVisibleSelectionDeprecated from SelectionAdjuster
4 years, 2 months ago (2016-10-04 10:30:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2391973002/1
4 years, 2 months ago (2016-10-04 10:30:40 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 11:44:14 UTC) #4
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 11:45:55 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/189778ba4d34566e1a237c4c21262a46c698f14c
Cr-Commit-Position: refs/heads/master@{#422756}

Powered by Google App Engine
This is Rietveld 408576698