Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 2391953002: Rewind zonelists in scopes when resetting rather than clearing (Closed)

Created:
4 years, 2 months ago by Toon Verwaest
Modified:
4 years, 2 months ago
Reviewers:
marja
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Rewind zonelists in scopes when resetting rather than clearing Clear also frees the memory, which isn't useful in the case of a zonelist. If we later want to use the list (e.g., because of aborting), that will cause additional allocations. BUG= Committed: https://crrev.com/a6ceec24830672d2fef78d95affa303273a29067 Cr-Commit-Position: refs/heads/master@{#39948}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/ast/scopes.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Toon Verwaest
ptal
4 years, 2 months ago (2016-10-04 09:14:13 UTC) #2
marja
lgtm
4 years, 2 months ago (2016-10-04 09:17:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2391953002/1
4 years, 2 months ago (2016-10-04 09:17:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 09:42:06 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 09:42:28 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a6ceec24830672d2fef78d95affa303273a29067
Cr-Commit-Position: refs/heads/master@{#39948}

Powered by Google App Engine
This is Rietveld 408576698