Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Unified Diff: net/quic/core/quic_received_packet_manager_test.cc

Issue 2391933005: Remove unused "bytes" argument from QuicReceivedPacketManager::RecordPacketReceived. No functional… (Closed)
Patch Set: Delete unused kBytes Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/quic_received_packet_manager.cc ('k') | net/quic/test_tools/quic_test_utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/quic_received_packet_manager_test.cc
diff --git a/net/quic/core/quic_received_packet_manager_test.cc b/net/quic/core/quic_received_packet_manager_test.cc
index 9784e1c646ddcc8c2e4948fc7cad85c3fa2115ba..acc9c0fea374d5905a5a1b7410a1ffff7df65b70 100644
--- a/net/quic/core/quic_received_packet_manager_test.cc
+++ b/net/quic/core/quic_received_packet_manager_test.cc
@@ -224,7 +224,7 @@ class QuicReceivedPacketManagerTest
QuicPacketHeader header;
header.packet_number = packet_number;
header.entropy_hash = entropy_hash;
- received_manager_.RecordPacketReceived(0u, header, receipt_time);
+ received_manager_.RecordPacketReceived(header, receipt_time);
}
QuicConnectionStats stats_;
@@ -328,9 +328,9 @@ TEST_P(QuicReceivedPacketManagerTest, SetCumulativeEntropyUpTo) {
TEST_P(QuicReceivedPacketManagerTest, DontWaitForPacketsBefore) {
QuicPacketHeader header;
header.packet_number = 2u;
- received_manager_.RecordPacketReceived(0u, header, QuicTime::Zero());
+ received_manager_.RecordPacketReceived(header, QuicTime::Zero());
header.packet_number = 7u;
- received_manager_.RecordPacketReceived(0u, header, QuicTime::Zero());
+ received_manager_.RecordPacketReceived(header, QuicTime::Zero());
EXPECT_TRUE(received_manager_.IsAwaitingPacket(3u));
EXPECT_TRUE(received_manager_.IsAwaitingPacket(6u));
EXPECT_TRUE(QuicReceivedPacketManagerPeer::DontWaitForPacketsBefore(
@@ -344,7 +344,7 @@ TEST_P(QuicReceivedPacketManagerTest, GetUpdatedAckFrame) {
header.packet_number = 2u;
QuicTime two_ms = QuicTime::Zero() + QuicTime::Delta::FromMilliseconds(2);
EXPECT_FALSE(received_manager_.ack_frame_updated());
- received_manager_.RecordPacketReceived(0u, header, two_ms);
+ received_manager_.RecordPacketReceived(header, two_ms);
EXPECT_TRUE(received_manager_.ack_frame_updated());
QuicFrame ack = received_manager_.GetUpdatedAckFrame(QuicTime::Zero());
@@ -365,11 +365,11 @@ TEST_P(QuicReceivedPacketManagerTest, GetUpdatedAckFrame) {
EXPECT_EQ(1u, ack.ack_frame->received_packet_times.size());
header.packet_number = 999u;
- received_manager_.RecordPacketReceived(0u, header, two_ms);
+ received_manager_.RecordPacketReceived(header, two_ms);
header.packet_number = 4u;
- received_manager_.RecordPacketReceived(0u, header, two_ms);
+ received_manager_.RecordPacketReceived(header, two_ms);
header.packet_number = 1000u;
- received_manager_.RecordPacketReceived(0u, header, two_ms);
+ received_manager_.RecordPacketReceived(header, two_ms);
EXPECT_TRUE(received_manager_.ack_frame_updated());
ack = received_manager_.GetUpdatedAckFrame(two_ms);
EXPECT_FALSE(received_manager_.ack_frame_updated());
« no previous file with comments | « net/quic/core/quic_received_packet_manager.cc ('k') | net/quic/test_tools/quic_test_utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698