Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1573)

Issue 2391933002: Safe Browsing: Only check origins for API checks. (Closed)

Created:
4 years, 2 months ago by kcarattini
Modified:
4 years, 2 months ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, vakh (use Gerrit instead), awoz
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Safe Browsing: Only check origins for API checks. The SB blacklist will contain information at the origin level so we shouldn't waste resources checking longer paths. BUG=561867, 647107, 543161 Committed: https://crrev.com/58011218715aba59b766b5886296b66e9c324824 Cr-Commit-Position: refs/heads/master@{#422986}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M components/safe_browsing_db/database_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/safe_browsing_db/v4_get_hash_protocol_manager.h View 1 chunk +3 lines, -3 lines 0 comments Download
M components/safe_browsing_db/v4_get_hash_protocol_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/safe_browsing_db/v4_get_hash_protocol_manager_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
kcarattini
4 years, 2 months ago (2016-10-04 06:16:41 UTC) #2
vakh (use Gerrit instead)
lgtm Can you please add bug 543161 also?
4 years, 2 months ago (2016-10-04 06:35:36 UTC) #4
Nathan Parker
lgtm
4 years, 2 months ago (2016-10-04 20:32:49 UTC) #5
kcarattini
On 2016/10/04 06:35:36, vakh (Varun Khaneja) wrote: > lgtm > > Can you please add ...
4 years, 2 months ago (2016-10-04 22:00:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2391933002/1
4 years, 2 months ago (2016-10-04 22:01:19 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 23:11:19 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 23:14:44 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/58011218715aba59b766b5886296b66e9c324824
Cr-Commit-Position: refs/heads/master@{#422986}

Powered by Google App Engine
This is Rietveld 408576698