Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Unified Diff: third_party/WebKit/Source/core/html/HTMLLinkElement.h

Issue 2391923002: Call checkCompleted() synchronously in HTMLLinkElement::dispatchPendingEvent() (Closed)
Patch Set: Rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/HTMLLinkElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/html/HTMLLinkElement.h
diff --git a/third_party/WebKit/Source/core/html/HTMLLinkElement.h b/third_party/WebKit/Source/core/html/HTMLLinkElement.h
index 37eedb725436ad022f45647e26130c98f2ba00eb..c7cefadced6213577485ed82f76601587d4265f3 100644
--- a/third_party/WebKit/Source/core/html/HTMLLinkElement.h
+++ b/third_party/WebKit/Source/core/html/HTMLLinkElement.h
@@ -88,7 +88,6 @@ class CORE_EXPORT HTMLLinkElement final : public HTMLElement,
DOMTokenList* sizes() const;
- void dispatchPendingEvent(std::unique_ptr<IncrementLoadEventDelayCount>);
void scheduleEvent();
// From LinkLoaderClient
@@ -120,6 +119,10 @@ class CORE_EXPORT HTMLLinkElement final : public HTMLElement,
void process();
static void processCallback(Node*);
+ // Always call this asynchronously because this can cause synchronous
+ // Document load event and JavaScript execution.
+ void dispatchPendingEvent(std::unique_ptr<IncrementLoadEventDelayCount>);
+
// From Node and subclassses
void parseAttribute(const AttributeModificationParams&) override;
InsertionNotificationRequest insertedInto(ContainerNode*) override;
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/HTMLLinkElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698