Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23919004: [NaCl SDK] Create a resources/ directory and move files to it. (Closed)

Created:
7 years, 3 months ago by binji
Modified:
7 years, 3 months ago
Reviewers:
Sam Clegg, noeallen
CC:
chromium-reviews, Sam Clegg
Visibility:
Public.

Description

[NaCl SDK] Create a resources/ directory and move files to it. * Move files out of the roout of examples/ to resources/ * Move files from examples/resources to resources/ * Move Makefile templates to resources/ and rename them. BUG=none R=sbc@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221741

Patch Set 1 #

Patch Set 2 : move httpd.cmd too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -992 lines) Patch
M native_client_sdk/src/build_tools/build_app.py View 3 chunks +3 lines, -3 lines 0 comments Download
M native_client_sdk/src/build_tools/build_paths.py View 1 chunk +1 line, -0 lines 0 comments Download
M native_client_sdk/src/build_tools/build_projects.py View 3 chunks +6 lines, -12 lines 0 comments Download
M native_client_sdk/src/build_tools/generate_make.py View 5 chunks +6 lines, -7 lines 0 comments Download
D native_client_sdk/src/build_tools/library.mk View 1 chunk +0 lines, -65 lines 0 comments Download
D native_client_sdk/src/build_tools/template.mk View 1 chunk +0 lines, -89 lines 0 comments Download
D native_client_sdk/src/examples/Makefile View 1 chunk +0 lines, -68 lines 0 comments Download
D native_client_sdk/src/examples/Makefile_gyp View 1 chunk +0 lines, -52 lines 0 comments Download
D native_client_sdk/src/examples/common.js View 1 chunk +0 lines, -439 lines 0 comments Download
D native_client_sdk/src/examples/favicon.ico View Binary file 0 comments Download
D native_client_sdk/src/examples/httpd.cmd View 1 1 chunk +0 lines, -8 lines 0 comments Download
D native_client_sdk/src/examples/resources/background.js View 1 chunk +0 lines, -13 lines 0 comments Download
D native_client_sdk/src/examples/resources/button_close.png View Binary file 0 comments Download
D native_client_sdk/src/examples/resources/button_close_hover.png View Binary file 0 comments Download
D native_client_sdk/src/examples/resources/icon128.png View Binary file 0 comments Download
D native_client_sdk/src/examples/resources/index.css View 1 chunk +0 lines, -88 lines 0 comments Download
D native_client_sdk/src/examples/resources/index.js View 1 chunk +0 lines, -72 lines 0 comments Download
D native_client_sdk/src/examples/resources/index.html.template View 1 chunk +0 lines, -45 lines 0 comments Download
D native_client_sdk/src/examples/resources/manifest.json.template View 1 chunk +0 lines, -23 lines 0 comments Download
D native_client_sdk/src/examples/resources/promo440.png View Binary file 0 comments Download
D native_client_sdk/src/examples/resources/screenshot_gles_1280.png View Binary file 0 comments Download
D native_client_sdk/src/examples/resources/screenshot_pi_1280.png View Binary file 0 comments Download
M native_client_sdk/src/examples/tutorial/debugging/example.dsc View 1 chunk +0 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/gmock/library.dsc View 1 chunk +0 lines, -1 line 0 comments Download
M native_client_sdk/src/libraries/ppapi_cpp/library.dsc View 1 chunk +0 lines, -1 line 0 comments Download
M native_client_sdk/src/libraries/sdk_util/library.dsc View 1 chunk +0 lines, -3 lines 0 comments Download
M native_client_sdk/src/libraries/xray/library.dsc View 1 chunk +0 lines, -3 lines 0 comments Download
A + native_client_sdk/src/resources/Makefile.example.template View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/resources/Makefile.index.template View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/resources/Makefile.library.template View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/resources/Makefile_gyp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/resources/background.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/resources/button_close.png View Binary file 0 comments Download
A + native_client_sdk/src/resources/button_close_hover.png View Binary file 0 comments Download
A + native_client_sdk/src/resources/common.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/resources/favicon.ico View Binary file 0 comments Download
A + native_client_sdk/src/resources/httpd.cmd View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/resources/icon128.png View Binary file 0 comments Download
A + native_client_sdk/src/resources/index.css View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/resources/index.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/resources/index.html.template View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/resources/manifest.json.template View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/resources/promo440.png View Binary file 0 comments Download
A + native_client_sdk/src/resources/screenshot_gles_1280.png View Binary file 0 comments Download
A + native_client_sdk/src/resources/screenshot_pi_1280.png View Binary file 0 comments Download
M native_client_sdk/src/tests/nacl_io_socket_test/example.dsc View 1 chunk +0 lines, -3 lines 0 comments Download
M native_client_sdk/src/tests/nacl_io_test/example.dsc View 1 chunk +0 lines, -2 lines 0 comments Download
M native_client_sdk/src/tests/sdk_util_test/example.dsc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
binji
7 years, 3 months ago (2013-09-05 21:16:59 UTC) #1
Sam Clegg
lgtm
7 years, 3 months ago (2013-09-05 21:26:09 UTC) #2
binji
Hm, can't run a tryjob because of the binary files. I've verified it locally, so ...
7 years, 3 months ago (2013-09-05 21:34:50 UTC) #3
binji
7 years, 3 months ago (2013-09-06 18:38:30 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 manually as r221741 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698