Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1696)

Issue 2391893002: Additional fields added to Memory Leak Detector proto (Closed)

Created:
4 years, 2 months ago by mwlodar
Modified:
4 years, 2 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Additional fields added to Memory Leak Detector proto Memory Leak Detector proto gets enriched with a message for collecting memory usage information from OS and fields describing the last increasing allocation trend for the suspected size and call stack. BUG=chromium:650347 Committed: https://crrev.com/1cfe9539a19cb6cdea82c91f78f9341418fa2d13 Cr-Commit-Position: refs/heads/master@{#422963}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -1 line) Patch
M components/metrics/proto/memory_leak_report.proto View 2 chunks +36 lines, -1 line 0 comments Download

Messages

Total messages: 18 (11 generated)
mwlodar
4 years, 2 months ago (2016-10-04 02:08:35 UTC) #7
Simon Que
On 2016/10/04 02:08:35, mwlodar wrote: lgtm
4 years, 2 months ago (2016-10-04 20:37:26 UTC) #8
mwlodar
4 years, 2 months ago (2016-10-04 21:13:49 UTC) #10
Alexei Svitkine (slow)
lgtm
4 years, 2 months ago (2016-10-04 21:14:25 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2391893002/1
4 years, 2 months ago (2016-10-04 22:13:54 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 22:20:20 UTC) #16
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 22:23:16 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1cfe9539a19cb6cdea82c91f78f9341418fa2d13
Cr-Commit-Position: refs/heads/master@{#422963}

Powered by Google App Engine
This is Rietveld 408576698