Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Unified Diff: content/browser/web_contents/web_contents_impl.h

Issue 2391883006: Mojo-ify implementation of screen orientation locking/unlocking. (Closed)
Patch Set: Ensure correct ordering between ViewMsg_Resize and screen orientation messages Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_impl.h
diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h
index 3afb1aab039d99d206c9b33af0d666dbd9d6c669..bfd4cb197fb75b8a188ba8d607c1fcbf8fed95c3 100644
--- a/content/browser/web_contents/web_contents_impl.h
+++ b/content/browser/web_contents/web_contents_impl.h
@@ -73,7 +73,7 @@ class RenderViewHostDelegateView;
class RenderWidgetHostImpl;
class RenderWidgetHostInputEventRouter;
class SavePackage;
-class ScreenOrientationDispatcherHost;
+class ScreenOrientationImpl;
class SiteInstance;
class TestWebContents;
class TextInputManager;
@@ -209,10 +209,6 @@ class CONTENT_EXPORT WebContentsImpl
WebContentsView* GetView() const;
- ScreenOrientationDispatcherHost* screen_orientation_dispatcher_host() {
- return screen_orientation_dispatcher_host_.get();
- }
-
bool should_normally_be_visible() { return should_normally_be_visible_; }
// Indicate if the window has been occluded, and pass this to the views, only
@@ -488,6 +484,7 @@ class CONTENT_EXPORT WebContentsImpl
int browser_plugin_instance_id) override;
device::GeolocationServiceContext* GetGeolocationServiceContext() override;
device::WakeLockServiceContext* GetWakeLockServiceContext() override;
+ ScreenOrientationImpl* GetScreenOrientation() override;
void EnterFullscreenMode(const GURL& origin) override;
void ExitFullscreenMode(bool will_cause_resize) override;
bool ShouldRouteMessageEvent(
@@ -1378,8 +1375,7 @@ class CONTENT_EXPORT WebContentsImpl
std::unique_ptr<device::WakeLockServiceContext> wake_lock_service_context_;
- std::unique_ptr<ScreenOrientationDispatcherHost>
- screen_orientation_dispatcher_host_;
+ std::unique_ptr<ScreenOrientationImpl> screen_orientation_;
std::unique_ptr<ManifestManagerHost> manifest_manager_host_;

Powered by Google App Engine
This is Rietveld 408576698