Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 2391883002: MemoryResourceProvider always uses the current platform (Closed)

Created:
4 years, 2 months ago by Brian Wilkerson
Modified:
4 years, 2 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

MemoryResourceProvider always uses the current platform R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/ef2a3b982cccdd407eb5f2ca74f4a95364c8d7ce

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -12 lines) Patch
M pkg/analyzer/lib/file_system/memory_file_system.dart View 5 chunks +12 lines, -9 lines 0 comments Download
M pkg/analyzer/test/embedder_tests.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analyzer/test/source/analysis_options_provider_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
I'll follow up with the utility method and test changes we discussed, but I'm curious ...
4 years, 2 months ago (2016-10-04 00:03:22 UTC) #2
scheglov
lgtm
4 years, 2 months ago (2016-10-04 01:07:30 UTC) #3
Brian Wilkerson
4 years, 2 months ago (2016-10-04 02:24:26 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ef2a3b982cccdd407eb5f2ca74f4a95364c8d7ce (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698