Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Unified Diff: services/ui/ws/display.cc

Issue 2391853002: Makes mus not bring window to front on activation changes (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/ui/ws/display.cc
diff --git a/services/ui/ws/display.cc b/services/ui/ws/display.cc
index f148f34a9867e5fb6dc76fb1ffe95d924c72bd64..d44955feec34ccbaee6147e9447747a84d9d403d 100644
--- a/services/ui/ws/display.cc
+++ b/services/ui/ws/display.cc
@@ -351,12 +351,9 @@ bool Display::CanHaveActiveChildren(ServerWindow* window) const {
void Display::OnActivationChanged(ServerWindow* old_active_window,
ServerWindow* new_active_window) {
- DCHECK_NE(new_active_window, old_active_window);
- if (new_active_window && new_active_window->parent()) {
- // Raise the new active window.
- // TODO(sad): Let the WM dictate whether to raise the window or not?
- new_active_window->parent()->StackChildAtTop(new_active_window);
- }
+ // Don't do anything here. We assume the windowmanager handles restacking. If
msw 2016/10/03 23:42:01 nit: 'window manager'?
sky 2016/10/03 23:53:29 Done.
+ // we did attempt to restack than we would have to ensure clients see the
+ // restack.
}
void Display::OnFocusChanged(FocusControllerChangeSource change_source,

Powered by Google App Engine
This is Rietveld 408576698