Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2391843003: [tools] Initialize global pages var in callstats.html (Closed)

Created:
4 years, 2 months ago by Camillo Bruni
Modified:
4 years, 2 months ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[tools] Initialize global pages var in callstats.html R=machenbach@chromium.org NOTRY=true BUG=chromium:611010 Committed: https://crrev.com/c80619129d8f20d97fd7961d36c4a029e5f04b57 Cr-Commit-Position: refs/heads/master@{#39958}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/callstats.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Camillo Bruni
PTAL seems like we're almost there :)
4 years, 2 months ago (2016-10-04 08:46:38 UTC) #1
Michael Achenbach
lgtm
4 years, 2 months ago (2016-10-04 14:41:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2391843003/1
4 years, 2 months ago (2016-10-04 14:42:12 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 14:44:50 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 14:45:09 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c80619129d8f20d97fd7961d36c4a029e5f04b57
Cr-Commit-Position: refs/heads/master@{#39958}

Powered by Google App Engine
This is Rietveld 408576698