Issue 239183007: Merge 262965 "Linux: App windows with frame: none now have resiz..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 239183007: Merge 262965 "Linux: App windows with frame: none now have resiz..." (Closed)

Created:
6 years, 8 months ago by Matt Giuca

Modified:
6 years, 8 months ago

Reviewers:
Matt Giuca

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/branches/1916/src/

Visibility:
Public.

Merge 262965 "Linux: App windows with frame: none now have resiz..." > Linux: App windows with frame: none now have resize handles. > > ChromeNativeAppWindowViews now installs the EasyResizeWindowTargeter > into the content window, not its root window. The root window does not > have a delegate, which means it doesn't handle events on Linux. > > BUG=357049 > COLLABORATOR=sadrul@chromium.org > TEST=Open Text chrome app. All edges and corners should be draggable to > resize the app. > > Review URL: https://codereview.chromium.org/224903022 TBR=mgiuca@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264054

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -6 lines)			Patch
	M	chrome/browser/ui/views/apps/chrome_native_app_window_views.cc	View		2 chunks	+7 lines, -4 lines	0 comments	Download
	M	chrome/browser/ui/views/apps/shaped_app_window_targeter_unittest.cc	View		2 chunks	+15 lines, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

Matt Giuca

6 years, 8 months ago (2014-04-16 01:33:03 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r264054 (tree was closed).