Trace the lifetime of CopyOutputRequest

Trace the lifetime of CopyOutputRequest

The async readback case can be hard to follow with existing traces. Add an async
lifetime trace for each valid CopyOutputRequest, making clear both the lifetime
and frequency of such requests.

BUG=321624
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266688

[jdduke (slow), 2014-04-25 17:34:59]

skyostil@: Would this be at all useful? We don't seem to have much in the way of
async readback trace coverage (or maybe I'm just not seeing it?).

[jdduke (slow), 2014-04-25 17:35:59]

https://codereview.chromium.org/239183003/diff/1/cc/output/copy_output_reques...
File cc/output/copy_output_request.cc (right):

https://codereview.chromium.org/239183003/diff/1/cc/output/copy_output_reques...
cc/output/copy_output_request.cc:46: TRACE_EVENT_ASYNC_END0("cc",
"CopyOutputRequest", this);
Oops, forgot to delete this line.

[Sami, 2014-04-25 20:20:53]

In theory you can reconstruct this from the surrounding events, but since I'm
lazy at heart I'm all for doing this -- especially since you want expensive
operations like this to stand out. lgtm!

[jdduke (slow), 2014-04-25 20:24:00]

On 2014/04/25 20:20:53, Sami wrote:
> In theory you can reconstruct this from the surrounding events, but since I'm
> lazy at heart I'm all for doing this -- especially since you want expensive
> operations like this to stand out. lgtm!

Yeah, I considered hooking in at different points, but it involved extra
bookkeeping to make sure we got the proper async termination. Thanks for review!

[jdduke (slow), 2014-04-25 20:26:10]

The CQ bit was checked by jdduke@chromium.org

[commit-bot: I haz the power, 2014-04-25 22:06:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jdduke@chromium.org/239183003/20001

[commit-bot: I haz the power, 2014-04-25 23:13:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-25 23:13:56]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_clang_dbg

[danakj, 2014-04-25 23:14:42]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-04-25 23:21:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jdduke@chromium.org/239183003/20001

[commit-bot: I haz the power, 2014-04-25 23:35:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-25 23:35:58]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_rel

[jdduke (slow), 2014-04-26 03:04:29]

The CQ bit was checked by jdduke@chromium.org

[commit-bot: I haz the power, 2014-04-26 03:06:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jdduke@chromium.org/239183003/40001

[commit-bot: I haz the power, 2014-04-26 03:47:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-26 03:47:18]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_chromeos_rel

[jdduke (slow), 2014-04-26 15:22:45]

The CQ bit was checked by jdduke@chromium.org

[commit-bot: I haz the power, 2014-04-26 15:23:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jdduke@chromium.org/239183003/40001

[commit-bot: I haz the power, 2014-04-26 16:04:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-26 16:04:35]

Try jobs failed on following builders:
  tryserver.chromium on chromium_presubmit

[jdduke (slow), 2014-04-28 15:07:29]

The CQ bit was checked by jdduke@chromium.org

[commit-bot: I haz the power, 2014-04-28 15:07:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jdduke@chromium.org/239183003/40001

[commit-bot: I haz the power, 2014-04-28 15:08:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-28 15:08:42]

Try jobs failed on following builders:
  tryserver.chromium on android_dbg_triggered_tests

[jdduke (slow), 2014-04-28 22:13:57]

The CQ bit was checked by jdduke@chromium.org

[commit-bot: I haz the power, 2014-04-28 22:16:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jdduke@chromium.org/239183003/40001

[commit-bot: I haz the power, 2014-04-28 23:31:44]

Change committed as 266688