appengine/findit/util_scripts/crash_queries/README.md - Issue 2391823006: [Findit] Add iterator and crash_iterator for delta test

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: appengine/findit/util_scripts/crash_queries/README.md

Issue 2391823006: [Findit] Add iterator and crash_iterator for delta test (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « appengine/findit/crash/crash_pipeline.py ('k') | appengine/findit/util_scripts/crash_queries/__init__.py » ('j') | appengine/findit/util_scripts/crash_queries/client_crash_iterator.py » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 ###################### Set up enviroment variables. #####################

	2 ##!/bin/bash

	3 #

	4 ## Notice:

	5 ## Source this script to setup the PYTHONPATH and other environment settings for

	6 ## pulling data from ClusterFuzz through App Engine Remote API. Command:

	7 ## source setup_enviroments.sh

	8 ## . setup_enviroments.sh
	wrengr 2016/10/05 18:41:58 should be "setup_environment"; the plural is weird should be "setup_environment"; the plural is weird. But also, no such file exists. I'd suggest `source README.md` except that everything here is commented out. Sharu Jiang 2016/10/06 18:16:56 This is the practice I used in delta test in clust Show quoted text On 2016/10/05 18:41:58, wrengr wrote: > should be "setup_environment"; the plural is weird. > > But also, no such file exists. I'd suggest `source README.md` except that > everything here is commented out. This is the practice I used in delta test in clusterfuzz, so people won't accidentally check in their paths, instead they can make their own local .sh copy. wrengr 2016/10/06 19:20:08 That makes sense. It'd be clearer if there were ## Show quoted text On 2016/10/06 18:16:56, sharu jiang wrote: > On 2016/10/05 18:41:58, wrengr wrote: > > should be "setup_environment"; the plural is weird. > > > > But also, no such file exists. I'd suggest `source README.md` except that > > everything here is commented out. > > This is the practice I used in delta test in clusterfuzz, so people won't > accidentally check in their paths, instead they can make their own local .sh > copy. That makes sense. It'd be clearer if there were ##-comments explaining that users should copy the file to setup_environment.sh and customize the path values, as part of the directions prior to the ##-comment about sourcing it.
	9 #

	10 ## This must be set to the directory in which Findit source code is

	11 ## checked out, eg: ~/chrome-internal if the checkout is in

	12 ## ~/chrome-internal/findit.

	13 #export FINDIT_ROOT_DIR='root/path/to/findit'

	14 #

	15 ## Since findit don't want to cover the tests of
	wrengr 2016/10/05 18:41:58 "don't" -> "doesn't" "the tests of"... of what? "don't" -> "doesn't" "the tests of"... of what? Sharu Jiang 2016/10/06 18:16:56 Done. Show quoted text On 2016/10/05 18:41:58, wrengr wrote: > "don't" -> "doesn't" > > "the tests of"... of what? Done.
	16 #export UTIL_SCRIPTS_DIR=$FINDIT_ROOT_DIR/util_scripts

	17 #

	18 ##This must be set to the third_party directory under findit.

	19 #export THIRD_PARTY_DIR=${FINDIT_ROOT_DIR}/third_party

	20 #

	21 ## This must be set to your appengine SDK directory.

	22 #APPENGINE_SDK_DIR='path/to/google_appengine'

	23 #

	24 #if [[ $PYTHONPATH != $APPENGINE_SDK_DIR ]]

	25 #then

	26 # export PYTHONPATH=$UTIL_SCRIPTS_DIR:$FINDIT_ROOT_DIR:$THIRD_PARTY_DIR:$APPENG INE_SDK_DIR

	27 #fi

	28 #

	29 ## This should be set to your app id.

	30 #export APP_ID="your app id"

	31 #

	32 ## This must be set to the directory to put local checkout in.

	33 #export CHECKOUT_ROOT_DIR='path/to/checkout/root/path'

OLD	NEW