|
|
DescriptionUse EXPECT_NEAR to compare float values
This patch uses EXPECT_NEAR to compare float values, to prevent comparison error. Previously "round" function was used to compare, but it was the cause of flakiness (see the issue for detail).
BUG=650925
TEST=Run tests 5 times on Win bots and observe no failure.
Committed: https://crrev.com/fbda6558904fcc065cfe88c47e3354a98b0b1d7b
Cr-Commit-Position: refs/heads/master@{#423937}
Patch Set 1 #
Messages
Total messages: 45 (38 generated)
The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Patchset #4 (id:60001) has been deleted
Patchset #5 (id:100001) has been deleted
Patchset #4 (id:80001) has been deleted
Patchset #2 (id:20001) has been deleted
Patchset #1 (id:1) has been deleted
Description was changed from ========== . BUG= ========== to ========== Use EXPECT_NEAR to compare float values This patch uses EXPECT_NEAR to compare float values, to prevent comparison error. Previously "round" function was used to compare, but it was the cause of flakiness (see the issue for detail). BUG=650925 ==========
yoshiki@chromium.org changed reviewers: + oshima@chromium.org
yoshiki@chromium.org changed reviewers: + sadrul@chromium.org - oshima@chromium.org
Description was changed from ========== Use EXPECT_NEAR to compare float values This patch uses EXPECT_NEAR to compare float values, to prevent comparison error. Previously "round" function was used to compare, but it was the cause of flakiness (see the issue for detail). BUG=650925 ========== to ========== Use EXPECT_NEAR to compare float values This patch uses EXPECT_NEAR to compare float values, to prevent comparison error. Previously "round" function was used to compare, but it was the cause of flakiness (see the issue for detail). BUG=650925 TEST=Run tests 5 times on Win bots. ==========
Description was changed from ========== Use EXPECT_NEAR to compare float values This patch uses EXPECT_NEAR to compare float values, to prevent comparison error. Previously "round" function was used to compare, but it was the cause of flakiness (see the issue for detail). BUG=650925 TEST=Run tests 5 times on Win bots. ========== to ========== Use EXPECT_NEAR to compare float values This patch uses EXPECT_NEAR to compare float values, to prevent comparison error. Previously "round" function was used to compare, but it was the cause of flakiness (see the issue for detail). BUG=650925 TEST=Run tests 5 times on Win bots and observe no failure. ==========
Sadrul, PTAL.
lgtm
The CQ bit was checked by yoshiki@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by gab@chromium.org
gab@chromium.org changed reviewers: - gab@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Use EXPECT_NEAR to compare float values This patch uses EXPECT_NEAR to compare float values, to prevent comparison error. Previously "round" function was used to compare, but it was the cause of flakiness (see the issue for detail). BUG=650925 TEST=Run tests 5 times on Win bots and observe no failure. ========== to ========== Use EXPECT_NEAR to compare float values This patch uses EXPECT_NEAR to compare float values, to prevent comparison error. Previously "round" function was used to compare, but it was the cause of flakiness (see the issue for detail). BUG=650925 TEST=Run tests 5 times on Win bots and observe no failure. ==========
Message was sent while issue was closed.
Committed patchset #1 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Use EXPECT_NEAR to compare float values This patch uses EXPECT_NEAR to compare float values, to prevent comparison error. Previously "round" function was used to compare, but it was the cause of flakiness (see the issue for detail). BUG=650925 TEST=Run tests 5 times on Win bots and observe no failure. ========== to ========== Use EXPECT_NEAR to compare float values This patch uses EXPECT_NEAR to compare float values, to prevent comparison error. Previously "round" function was used to compare, but it was the cause of flakiness (see the issue for detail). BUG=650925 TEST=Run tests 5 times on Win bots and observe no failure. Committed: https://crrev.com/fbda6558904fcc065cfe88c47e3354a98b0b1d7b Cr-Commit-Position: refs/heads/master@{#423937} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/fbda6558904fcc065cfe88c47e3354a98b0b1d7b Cr-Commit-Position: refs/heads/master@{#423937} |