Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(638)

Issue 2391823004: Use EXPECT_NEAR to compare float values (Closed)

Created:
4 years, 2 months ago by yoshiki
Modified:
4 years, 2 months ago
Reviewers:
sadrul
CC:
chromium-reviews, kalyank, sadrul, gab
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use EXPECT_NEAR to compare float values This patch uses EXPECT_NEAR to compare float values, to prevent comparison error. Previously "round" function was used to compare, but it was the cause of flakiness (see the issue for detail). BUG=650925 TEST=Run tests 5 times on Win bots and observe no failure. Committed: https://crrev.com/fbda6558904fcc065cfe88c47e3354a98b0b1d7b Cr-Commit-Position: refs/heads/master@{#423937}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M ash/system/toast/toast_manager_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 45 (38 generated)
yoshiki
Sadrul, PTAL.
4 years, 2 months ago (2016-10-05 19:16:38 UTC) #33
sadrul
lgtm
4 years, 2 months ago (2016-10-06 14:11:37 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2391823004/40001
4 years, 2 months ago (2016-10-07 02:22:15 UTC) #36
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/82312) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 2 months ago (2016-10-07 02:24:28 UTC) #38
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2391823004/40001
4 years, 2 months ago (2016-10-07 19:29:51 UTC) #41
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 2 months ago (2016-10-07 19:43:25 UTC) #43
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 19:46:50 UTC) #45
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fbda6558904fcc065cfe88c47e3354a98b0b1d7b
Cr-Commit-Position: refs/heads/master@{#423937}

Powered by Google App Engine
This is Rietveld 408576698