Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 2391813002: Remove parts of webkitpy.common.system.logutils that are unused. (Closed)

Created:
4 years, 2 months ago by qyearsley
Modified:
4 years, 2 months ago
Reviewers:
jeffcarp, dcheng
CC:
blink-reviews, chromium-reviews, Dirk Pranke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove parts of webkitpy.common.system.logutils that are unused. Committed: https://crrev.com/bbe7d7f453a8d0734f8a6570e761bc1e5ead2e2f Cr-Commit-Position: refs/heads/master@{#422645}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -128 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/logutils.py View 1 chunk +0 lines, -95 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/logutils_unittest.py View 2 chunks +2 lines, -33 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
qyearsley
This CL just prunes away some unused helper code in webkitpy.
4 years, 2 months ago (2016-10-03 23:32:26 UTC) #2
jeffcarp
lgtm
4 years, 2 months ago (2016-10-04 00:08:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2391813002/1
4 years, 2 months ago (2016-10-04 00:10:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 01:04:07 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 01:07:26 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bbe7d7f453a8d0734f8a6570e761bc1e5ead2e2f
Cr-Commit-Position: refs/heads/master@{#422645}

Powered by Google App Engine
This is Rietveld 408576698