Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2391803003: MD Settings: change "Yay!" to "Cheers." because Alan said so (Closed)

Created:
4 years, 2 months ago by Dan Beam
Modified:
4 years, 2 months ago
Reviewers:
dschuyler
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: change "Yay!" to "Cheers." because Alan said so R=dschuyler@chromium.org BUG=651720 Committed: https://crrev.com/fe490e334ec2d4a543e0d1be91aacb6abaec688b Cr-Commit-Position: refs/heads/master@{#422873}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/app/settings_chromium_strings.grdp View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/settings_google_chrome_strings.grdp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
Dan Beam
4 years, 2 months ago (2016-10-04 04:08:52 UTC) #2
dschuyler
lgtm
4 years, 2 months ago (2016-10-04 18:42:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2391803003/1
4 years, 2 months ago (2016-10-04 18:47:49 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 18:54:18 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 18:59:44 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fe490e334ec2d4a543e0d1be91aacb6abaec688b
Cr-Commit-Position: refs/heads/master@{#422873}

Powered by Google App Engine
This is Rietveld 408576698