Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2391773002: [DevTools] Update XHR breakpoint enabled checkbox when needed (Closed)

Created:
4 years, 2 months ago by kozy
Modified:
4 years, 2 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Update XHR breakpoint enabled checkbox when needed If new XHR breakpoint with existing url is added then we need to enable existing breakpoint. BUG=chromium:532411 R=dgozman@chromium.org Committed: https://crrev.com/eff479686ed99ea5da6781bc5b7c1a028108ce69 Cr-Commit-Position: refs/heads/master@{#422593}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
kozy
Dmitry, please take a look!
4 years, 2 months ago (2016-10-03 21:18:01 UTC) #1
dgozman
lgtm
4 years, 2 months ago (2016-10-03 21:44:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2391773002/1
4 years, 2 months ago (2016-10-03 21:46:05 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-03 23:23:16 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 23:26:58 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eff479686ed99ea5da6781bc5b7c1a028108ce69
Cr-Commit-Position: refs/heads/master@{#422593}

Powered by Google App Engine
This is Rietveld 408576698