Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 2391763003: Move permissions manifest key to //extensions (Closed)

Created:
4 years, 2 months ago by michaelpg
Modified:
4 years, 2 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move permissions manifest key to //extensions Permissions are parsed in //extensions. Moving the manifset key to the //extensions _manifest_features.json file would prevent app_shell from warning about an unknown "permissions" key (if app_shell warnings were printed). BUG=652006 R=rdevlin.cronin@chromium.org Committed: https://crrev.com/a525387e44b256f162626c25fa14dd199d9c4094 Cr-Commit-Position: refs/heads/master@{#422632}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M chrome/common/extensions/api/_manifest_features.json View 1 chunk +0 lines, -6 lines 0 comments Download
M extensions/common/api/_manifest_features.json View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
michaelpg
What we talked about
4 years, 2 months ago (2016-10-03 23:09:36 UTC) #1
Devlin
lgtm as long as the bots are happy.
4 years, 2 months ago (2016-10-03 23:16:43 UTC) #2
michaelpg
On 2016/10/03 23:16:43, Devlin wrote: > lgtm as long as the bots are happy. I ...
4 years, 2 months ago (2016-10-03 23:18:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2391763003/1
4 years, 2 months ago (2016-10-03 23:19:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 00:36:42 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 00:39:37 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a525387e44b256f162626c25fa14dd199d9c4094
Cr-Commit-Position: refs/heads/master@{#422632}

Powered by Google App Engine
This is Rietveld 408576698