Make the flash permission prompt work properly on file: URLs

Make the flash permission prompt work properly on file: URLs

Currently the prompt gets displayed but nothing happens when it is clicked.
This ensures that a blanket allow/block for all file: URLs is persisted.

BUG=649223
Committed: https://crrev.com/320921bb1bd65a1d1627399be554fdf2bf8dcb05
Cr-Commit-Position: refs/heads/master@{#423352}

[raymes, 2016-10-05 04:50:38]

raymes@chromium.org changed reviewers:
+ tommycli@chromium.org

[raymes, 2016-10-05 04:50:38]

Tommy, ptal. I don't feel convinced about this solution, but it may be good
enough as a short term solution. Alternatively we just stick with allow or block
everywhere.

[raymes, 2016-10-05 04:51:27]

https://codereview.chromium.org/2391743005/diff/1/chrome/test/data/permission...
File chrome/test/data/permissions/flash2.html (right):

https://codereview.chromium.org/2391743005/diff/1/chrome/test/data/permission...
chrome/test/data/permissions/flash2.html:34: }
I should probably pull out the common code but I can do this if we decide to go
ahead with this.

[tommycli, 2016-10-05 16:26:21]

lgtm sans:

https://codereview.chromium.org/2391743005/diff/1/chrome/browser/permissions/...
File chrome/browser/permissions/permission_context_base.cc (right):

https://codereview.chromium.org/2391743005/diff/1/chrome/browser/permissions/...
chrome/browser/permissions/permission_context_base.cc:296:
DCHECK(!embedding_origin.SchemeIsFile());
Are you sure this won't cause a crash for other data types, such as image /
camera?

https://codereview.chromium.org/2391743005/diff/1/chrome/test/data/permission...
File chrome/test/data/permissions/flash2.html (right):

https://codereview.chromium.org/2391743005/diff/1/chrome/test/data/permission...
chrome/test/data/permissions/flash2.html:34: }
On 2016/10/05 04:51:27, raymes wrote:
> I should probably pull out the common code but I can do this if we decide to
go
> ahead with this.

Yes, that would be good.

[raymes, 2016-10-05 23:15:53]

https://codereview.chromium.org/2391743005/diff/1/chrome/browser/permissions/...
File chrome/browser/permissions/permission_context_base.cc (right):

https://codereview.chromium.org/2391743005/diff/1/chrome/browser/permissions/...
chrome/browser/permissions/permission_context_base.cc:296:
DCHECK(!embedding_origin.SchemeIsFile());
On 2016/10/05 16:26:20, tommycli wrote:
> Are you sure this won't cause a crash for other data types, such as image /
> camera?

Not that I know of - but if they do, I'm interested to know about it :)

https://codereview.chromium.org/2391743005/diff/1/chrome/test/data/permission...
File chrome/test/data/permissions/flash2.html (right):

https://codereview.chromium.org/2391743005/diff/1/chrome/test/data/permission...
chrome/test/data/permissions/flash2.html:34: }
On 2016/10/05 16:26:20, tommycli wrote:
> On 2016/10/05 04:51:27, raymes wrote:
> > I should probably pull out the common code but I can do this if we decide to
> go
> > ahead with this.
> 
> Yes, that would be good.

Done.

[raymes, 2016-10-05 23:16:00]

The CQ bit was checked by raymes@chromium.org

[raymes, 2016-10-05 23:16:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
tommycli@chromium.org
Link to the patchset: https://codereview.chromium.org/2391743005/#ps20001
(title: "test prompt")

[commit-bot: I haz the power, 2016-10-05 23:16:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 00:23:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-06 00:25:15]

Description was changed from

==========
Make the flash permission prompt work properly on file: URLs

Currently the prompt gets displayed but nothing happens when it is clicked.
This ensures that a blanket allow/block for all file: URLs is persisted.

BUG=649223
==========

to

==========
Make the flash permission prompt work properly on file: URLs

Currently the prompt gets displayed but nothing happens when it is clicked.
This ensures that a blanket allow/block for all file: URLs is persisted.

BUG=649223

Committed: https://crrev.com/320921bb1bd65a1d1627399be554fdf2bf8dcb05
Cr-Commit-Position: refs/heads/master@{#423352}
==========

[commit-bot: I haz the power, 2016-10-06 00:25:16]

Patchset 2 (id:??) landed as
https://crrev.com/320921bb1bd65a1d1627399be554fdf2bf8dcb05
Cr-Commit-Position: refs/heads/master@{#423352}