Use FileDescriptorWatcher in ServiceHelper.

Use FileDescriptorWatcher in ServiceHelper.

FileDescriptorWatcher is a new API that should be used
instead of MessageLoopForIO::WatchFileDescriptor
when possible.

BUG=645114
Committed: https://crrev.com/205d3f2d91dd335957d7dfdb89e1fca833053f38
Cr-Commit-Position: refs/heads/master@{#422538}

[fdoray, 2016-10-03 20:42:35]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-03 20:43:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 20:52:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-03 20:52:58]

Dry run: This issue passed the CQ dry run.

[fdoray, 2016-10-03 21:07:02]

Description was changed from

==========
Use FileDescriptorWatcher in ServiceHelper.

This allows ServiceHelper to be used from any thread that
instantiates a FileDescriptorWatcher (not just threads that run
a MessageLoopForIO). This will facilitate the migration of
BrowserThreads to base/task_scheduler.

BUG=645114
==========

to

==========
Use FileDescriptorWatcher in ServiceHelper.

FileDescriptorWatcher is a new API that should be used
instead of MessageLoopForIO::WatchFileDescriptor
when possible.

BUG=645114
==========

[fdoray, 2016-10-03 21:07:44]

fdoray@chromium.org changed reviewers:
+ elijahtaylor@chromium.org

[fdoray, 2016-10-03 21:07:44]

PTAL

[Luis Héctor Chávez, 2016-10-03 21:12:45]

lhchavez@chromium.org changed reviewers:
+ lhchavez@chromium.org

[Luis Héctor Chávez, 2016-10-03 21:12:45]

rs-lgtm on behalf of elijahtaylor1. We never ended up using that code, so I
think I'll go delete it soon.

[fdoray, 2016-10-03 21:13:57]

On 2016/10/03 21:12:45, Luis Héctor Chávez wrote:
> rs-lgtm on behalf of elijahtaylor1. We never ended up using that code, so I
> think I'll go delete it soon.

Good! Landing this CL to reduce the number of WatchFileDescriptor call sites and
I'll let you delete it later.

[fdoray, 2016-10-03 21:14:02]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2016-10-03 21:14:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 21:30:14]

Description was changed from

==========
Use FileDescriptorWatcher in ServiceHelper.

FileDescriptorWatcher is a new API that should be used
instead of MessageLoopForIO::WatchFileDescriptor
when possible.

BUG=645114
==========

to

==========
Use FileDescriptorWatcher in ServiceHelper.

FileDescriptorWatcher is a new API that should be used
instead of MessageLoopForIO::WatchFileDescriptor
when possible.

BUG=645114
==========

[commit-bot: I haz the power, 2016-10-03 21:30:15]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-03 21:34:17]

Description was changed from

==========
Use FileDescriptorWatcher in ServiceHelper.

FileDescriptorWatcher is a new API that should be used
instead of MessageLoopForIO::WatchFileDescriptor
when possible.

BUG=645114
==========

to

==========
Use FileDescriptorWatcher in ServiceHelper.

FileDescriptorWatcher is a new API that should be used
instead of MessageLoopForIO::WatchFileDescriptor
when possible.

BUG=645114

Committed: https://crrev.com/205d3f2d91dd335957d7dfdb89e1fca833053f38
Cr-Commit-Position: refs/heads/master@{#422538}
==========

[commit-bot: I haz the power, 2016-10-03 21:34:18]

Patchset 2 (id:??) landed as
https://crrev.com/205d3f2d91dd335957d7dfdb89e1fca833053f38
Cr-Commit-Position: refs/heads/master@{#422538}