Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(984)

Issue 2391723006: Prune createVisibleSelectionDeprecated from CreateLinkCommand (Closed)

Created:
4 years, 2 months ago by Xiaocheng
Modified:
4 years, 2 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prune createVisibleSelectionDeprecated from CreateLinkCommand BUG=651373 Committed: https://crrev.com/1f842237fbe23e8b17085725c49e2829f9927fc3 Cr-Commit-Position: refs/heads/master@{#423394}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/WebKit/Source/core/editing/commands/CreateLinkCommand.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Xiaocheng
PTAL.
4 years, 2 months ago (2016-10-06 01:31:44 UTC) #6
yosin_UTC9
lgtm
4 years, 2 months ago (2016-10-06 02:05:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2391723006/1
4 years, 2 months ago (2016-10-06 02:06:07 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-06 02:12:29 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 02:16:32 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1f842237fbe23e8b17085725c49e2829f9927fc3
Cr-Commit-Position: refs/heads/master@{#423394}

Powered by Google App Engine
This is Rietveld 408576698