[Mac Fix-It] Removed usage of deprecated resource fork API.

[Mac Fix-It] Removed usage of deprecated resource fork API.

There is no modern API to open resource forks on macOS. Currently used
API is deprecated and its usage should be removed as a part of
"Chrome Mac Deployment Target Fix-It". |URLFromInetloc| allows opening
of webloc files created by Safari, which works fine just by reading data
from webloc plist. New implementation will not open resource forks, but
it's very unlikely that they would exist on modern macOS.

BUG=650805
Committed: https://crrev.com/a1b9e0379d00e4d1711aaf97581c0dd0ac9c21c6
Cr-Commit-Position: refs/heads/master@{#423427}

[Eugene But (OOO till 7-30), 2016-10-04 05:19:46]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 05:19:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 05:52:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 05:52:15]

Dry run: This issue passed the CQ dry run.

[Eugene But (OOO till 7-30), 2016-10-06 00:26:39]

eugenebut@chromium.org changed reviewers:
+ avi@chromium.org

[Avi (use Gerrit), 2016-10-06 03:26:16]

LGTM.

I was hoping this wasn't used much, but it is called from the drag-and-drop code
imported, and _that_ code is used all over the place.

Sigh.

https://codereview.chromium.org/2391653003/diff/1/third_party/mozilla/NSURL+U...
File third_party/mozilla/NSURL+Utils.m (right):

https://codereview.chromium.org/2391653003/diff/1/third_party/mozilla/NSURL+U...
third_party/mozilla/NSURL+Utils.m:67: //// Begin Google Modified
Indent 2.

[Eugene But (OOO till 7-30), 2016-10-06 03:40:50]

Thanks for quick review.

https://codereview.chromium.org/2391653003/diff/1/third_party/mozilla/NSURL+U...
File third_party/mozilla/NSURL+Utils.m (right):

https://codereview.chromium.org/2391653003/diff/1/third_party/mozilla/NSURL+U...
third_party/mozilla/NSURL+Utils.m:67: //// Begin Google Modified
On 2016/10/06 03:26:16, Avi wrote:
> Indent 2.

Done. Sorry about that.

[Eugene But (OOO till 7-30), 2016-10-06 03:40:54]

The CQ bit was checked by eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2016-10-06 03:40:54]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org
Link to the patchset: https://codereview.chromium.org/2391653003/#ps20001
(title: "Addressed review comments")

[commit-bot: I haz the power, 2016-10-06 03:41:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 04:10:52]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-06 04:12:24]

Description was changed from

==========
[Mac Fix-It] Removed usage of deprecated resource fork API.

There is no modern API to open resource forks on macOS. Currently used
API is deprecated and its usage should be removed as a part of
"Chrome Mac Deployment Target Fix-It". |URLFromInetloc| allows opening
of webloc files created by Safari, which works fine just by reading data
from webloc plist. New implementation will not open resource forks, but
it's very unlikely that they would exist on modern macOS.

BUG=650805
==========

to

==========
[Mac Fix-It] Removed usage of deprecated resource fork API.

There is no modern API to open resource forks on macOS. Currently used
API is deprecated and its usage should be removed as a part of
"Chrome Mac Deployment Target Fix-It". |URLFromInetloc| allows opening
of webloc files created by Safari, which works fine just by reading data
from webloc plist. New implementation will not open resource forks, but
it's very unlikely that they would exist on modern macOS.

BUG=650805

Committed: https://crrev.com/a1b9e0379d00e4d1711aaf97581c0dd0ac9c21c6
Cr-Commit-Position: refs/heads/master@{#423427}
==========

[commit-bot: I haz the power, 2016-10-06 04:12:26]

Patchset 2 (id:??) landed as
https://crrev.com/a1b9e0379d00e4d1711aaf97581c0dd0ac9c21c6
Cr-Commit-Position: refs/heads/master@{#423427}