Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2391643004: Revert of Block top-level navigations to nested URLs with extension origins from non-extension procs (Closed)

Created:
4 years, 2 months ago by alexmos
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Revert of Block top-level navigations to nested URLs with extension origins from non-extension processes. (patchset #1 id:1 of https://codereview.chromium.org/2366973002/ ) Reason for revert: Broke blob: loads in <webview>. See https://bugs.chromium.org/p/chromium/issues/detail?id=652077 Original issue's description: > Block top-level navigations to nested URLs with extension origins from non-extension processes. > > Before this CL, it was possible for a web iframe with an unblessed > extension frame to exploit the renderer, create a blob: or filesystem: > URL in the extension frame context, then create a new top-level window > and navigate it to that URL, which could end up putting the new window > into a privileged extension process running attacker's code. > > BUG=645028 > > Review-Url: https://codereview.chromium.org/2345473003 > Cr-Commit-Position: refs/heads/master@{#419019} > (cherry picked from commit 4bfdc9292a6161980ba9a7a469d2d4515bebc6dd) > > Committed: https://chromium.googlesource.com/chromium/src/+/dbf71ae0ae30ffd84974aebf1bc7fefe329d5091 TBR=nasko@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=645028 # Adding these as instructed by commit-bot: NOTRY=true NOPRESUBMIT=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -237 lines) Patch
M chrome/browser/extensions/process_manager_browsertest.cc View 5 chunks +0 lines, -221 lines 0 comments Download
M chrome/browser/net/chrome_extensions_network_delegate.cc View 2 chunks +0 lines, -16 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
alexmos
Created Revert of Block top-level navigations to nested URLs with extension origins from non-extension processes.
4 years, 2 months ago (2016-10-04 16:41:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2391643004/1
4 years, 2 months ago (2016-10-04 16:50:02 UTC) #10
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years, 2 months ago (2016-10-04 16:50:05 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2391643004/1
4 years, 2 months ago (2016-10-04 16:51:55 UTC) #15
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 16:56:25 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698