[scheduler] Change ThreadLoadTracker to use only recent data.

third_party/WebKit/Source/platform/scheduler/base/thread_load_tracker.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef THIRD_PARTY_WEBKIT_SOURCE_PLATFORM_SCHEDULER_RENDERER_RENDERER_LOAD_TRACKER_H_
 #define THIRD_PARTY_WEBKIT_SOURCE_PLATFORM_SCHEDULER_RENDERER_RENDERER_LOAD_TRACKER_H_
 
+#include <queue>

[alex clarke (OOO till 29th), 2016/10/05 15:25:23]

Looks like this is no longer used.

[altimin, 2016/10/05 16:26:56]

Done.

+
 #include "base/callback.h"
 #include "base/macros.h"
 #include "base/time/time.h"
 #include "public/platform/WebCommon.h"
 
 namespace blink {
 namespace scheduler {
 
 // This class tracks thread load level, i.e. percentage of wall time spent
 // running tasks.
 // In order to avoid bias it reports load level at regular intervals.
+// It reports every |reporting_interval_| average thread load level in

[alex clarke (OOO till 29th), 2016/10/05 15:25:23]

Every |reporting_interval_| time units, it reports the average thread load level
computed using a sliding window of width |reporting_interval_|.

[altimin, 2016/10/05 16:26:56]

Done.

+// sliding window of |reporting_interval_| width.
 class BLINK_PLATFORM_EXPORT ThreadLoadTracker {
  public:
   // Callback is called with (current_time, load_level) parameters.
   using Callback = base::Callback<void(base::TimeTicks, double)>;
 
   ThreadLoadTracker(base::TimeTicks now, const Callback& callback);
   ~ThreadLoadTracker();
 
   void Pause(base::TimeTicks now);
   void Resume(base::TimeTicks now);
@@ skipping 11 matching lines @@
 
   // This function advances |time_| to |now|, calling |callback_|
   // in the process (multiple times if needed).
   void Advance(base::TimeTicks now, TaskState task_state);
 
   double Load();
 
   // |time_| is the last timestamp LoadTracker knows about.
   base::TimeTicks time_;
   base::TimeTicks next_reporting_time_;
+  // Total period for which this LoadTracker was active. Needed to discard
+  // first |waiting_period_| time.
+  base::TimeDelta recorded_time_;

[Sami, 2016/10/05 15:28:13]

Would |active_time_| or maybe |total_active_time_| be a better name for this?

[altimin, 2016/10/05 16:26:56]

Done.

 
   ThreadState thread_state_;
   base::TimeTicks last_state_change_time_;
 
-  base::TimeDelta total_time_;
-  base::TimeDelta total_runtime_;
-
   // Start reporting values after |waiting_period_|.
   base::TimeDelta waiting_period_;
   base::TimeDelta reporting_interval_;
 
+  // Recorded run time in bucket

[Sami, 2016/10/05 15:28:13]

s/bucket/window./? (Just wanted to avoid mixing these terms -- especially
together with UMA.)

[altimin, 2016/10/05 16:26:56]

Done.

+  // [next_reporting_time - reporting_interval, next_reporting_time].
+  base::TimeDelta run_time_inside_window_;
+
   Callback callback_;
 
   DISALLOW_COPY_AND_ASSIGN(ThreadLoadTracker);
 };
 
 }  // namespace scheduler
 }  // namespace blink
 
 #endif  // THIRD_PARTY_WEBKIT_SOURCE_PLATFORM_SCHEDULER_RENDERER_RENDERER_LOAD_TRACKER_H_