[Mac] Remove usage of deprecated FNNotifyByPath().

[Mac] Remove usage of deprecated FNNotifyByPath().

This moves to using -[NSWorkspace noteFileSystemChanged:], which internally
strips the last path component and calls the deprecated function.

BUG=650794
R=avi@chromium.org

Committed: https://crrev.com/ea963b6148fe1cb2b425a0e527883a830b3e16e7
Cr-Commit-Position: refs/heads/master@{#422977}

[Robert Sesek, 2016-10-04 20:58:42]

The CQ bit was checked by rsesek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 20:59:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 21:45:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 21:45:47]

Dry run: This issue passed the CQ dry run.

[Avi (use Gerrit), 2016-10-04 22:12:29]

lgtm

https://codereview.chromium.org/2391573004/diff/1/chrome/browser/download/dow...
File chrome/browser/download/download_status_updater_mac.mm (right):

https://codereview.chromium.org/2391573004/diff/1/chrome/browser/download/dow...
chrome/browser/download/download_status_updater_mac.mm:245: [[NSWorkspace
sharedWorkspace] noteFileSystemChanged:download_path];
-noteFileSystemChanged: has the note:

"Use of this method is discouraged. If you want to track changes to files and
directories, use the FSEvents API described in FSEvents Reference."

Yet I cannot figure out how any of the functions in the FSEvents API would be
applicable.

Huh.

[Robert Sesek, 2016-10-04 22:38:49]

https://codereview.chromium.org/2391573004/diff/1/chrome/browser/download/dow...
File chrome/browser/download/download_status_updater_mac.mm (right):

https://codereview.chromium.org/2391573004/diff/1/chrome/browser/download/dow...
chrome/browser/download/download_status_updater_mac.mm:245: [[NSWorkspace
sharedWorkspace] noteFileSystemChanged:download_path];
On 2016/10/04 22:12:29, Avi wrote:
> -noteFileSystemChanged: has the note:
> 
> "Use of this method is discouraged. If you want to track changes to files and
> directories, use the FSEvents API described in FSEvents Reference."
> 
> Yet I cannot figure out how any of the functions in the FSEvents API would be
> applicable.
> 
> Huh.

Yes, as far as I know, the only public FSEvents APIs are to observe the event
stream.

[Robert Sesek, 2016-10-04 22:39:06]

The CQ bit was checked by rsesek@chromium.org

[commit-bot: I haz the power, 2016-10-04 22:39:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 22:46:03]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-04 22:48:06]

Description was changed from

==========
[Mac] Remove usage of deprecated FNNotifyByPath().

This moves to using -[NSWorkspace noteFileSystemChanged:], which internally
strips the last path component and calls the deprecated function.

BUG=650794
R=avi@chromium.org
==========

to

==========
[Mac] Remove usage of deprecated FNNotifyByPath().

This moves to using -[NSWorkspace noteFileSystemChanged:], which internally
strips the last path component and calls the deprecated function.

BUG=650794
R=avi@chromium.org

Committed: https://crrev.com/ea963b6148fe1cb2b425a0e527883a830b3e16e7
Cr-Commit-Position: refs/heads/master@{#422977}
==========

[commit-bot: I haz the power, 2016-10-04 22:48:07]

Patchset 1 (id:??) landed as
https://crrev.com/ea963b6148fe1cb2b425a0e527883a830b3e16e7
Cr-Commit-Position: refs/heads/master@{#422977}