Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 2391533002: [turbofan] Mark for non-concurrent recompilation on OSR (Closed)

Created:
4 years, 2 months ago by klaasb
Modified:
4 years, 2 months ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Mark for non-concurrent recompilation on OSR Re-enable marking functions for optimized compilation on the next call when using OSR. We would previously do this for all functions. However, it only benefits functions marked for concurrent recompilation. These would potentially run unoptimized again and be OSRed again. In addition any function that already was optimized concurrently had it's optimized code removed and would have been recompiled. Functions to be baselined would skip that and possibly deopt. BUG=chromium:651042 Committed: https://crrev.com/660d11a217855f9704dacc106bbda46a249c2b77 Cr-Commit-Position: refs/heads/master@{#39934}

Patch Set 1 #

Patch Set 2 : fix compile #

Patch Set 3 : reword comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M src/runtime/runtime-compiler.cc View 1 2 1 chunk +14 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
rmcilroy
LGTM, thanks.
4 years, 2 months ago (2016-10-03 14:56:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2391533002/40001
4 years, 2 months ago (2016-10-03 16:22:19 UTC) #4
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-03 16:45:00 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 16:45:22 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/660d11a217855f9704dacc106bbda46a249c2b77
Cr-Commit-Position: refs/heads/master@{#39934}

Powered by Google App Engine
This is Rietveld 408576698