Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 239153006: Try to fix runhooks_wrapper.py on Windows after r263959. (Closed)

Created:
6 years, 8 months ago by Nico
Modified:
6 years, 8 months ago
Reviewers:
iannucci
CC:
chromium-reviews, cmp-cc_chromium.org, ilevy-cc_chromium.org, kjellander+cc_chromium.org
Visibility:
Public.

Description

Try to fix runhooks_wrapper.py on Windows after r263959. It's currently failing on Windows: http://build.chromium.org/p/chromium.fyi/builders/Chromium%20Win%20Ninja%20Goma%20%28shared%29/builds/27608/steps/runhooks/logs/stdio gclient runhooks Traceback (most recent call last): File "..\..\..\scripts\slave\runhooks_wrapper.py", line 49, in <module> sys.exit(main()) File "..\..\..\scripts\slave\runhooks_wrapper.py", line 45, in main return chromium_utils.RunCommand(['gclient', 'runhooks']) File "C:\b\build\scripts\common\chromium_utils.py", line 868, in RunCommand bufsize=0, **kwargs) File "C:\b\depot_tools\python276_bin\lib\subprocess.py", line 709, in __init__ errread, errwrite) File "C:\b\depot_tools\python276_bin\lib\subprocess.py", line 957, in _execute_child startupinfo) WindowsError: [Error 2] The system cannot find the file specified BUG=332697 TBR=iannucci@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=263974

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M build/scripts/slave/runhooks_wrapper.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Nico
6 years, 8 months ago (2014-04-15 19:46:39 UTC) #1
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 8 months ago (2014-04-15 19:46:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/239153006/1
6 years, 8 months ago (2014-04-15 19:46:55 UTC) #3
commit-bot: I haz the power
Change committed as 263974
6 years, 8 months ago (2014-04-15 19:47:45 UTC) #4
iannucci
On 2014/04/15 19:47:45, I haz the power (commit-bot) wrote: > Change committed as 263974 lgtm ...
6 years, 8 months ago (2014-04-15 19:58:35 UTC) #5
iannucci
On 2014/04/15 19:58:35, iannucci wrote: > On 2014/04/15 19:47:45, I haz the power (commit-bot) wrote: ...
6 years, 8 months ago (2014-04-15 19:59:11 UTC) #6
Nico
6 years, 8 months ago (2014-04-15 20:14:07 UTC) #7
Message was sent while issue was closed.
Yes, this helped. (Sorry, I left the "this helped" comment on the other review.)

Powered by Google App Engine
This is Rietveld 408576698