Issue 239153004: [CSS Shapes] Remove some leftover shape-inside code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 239153004: [CSS Shapes] Remove some leftover shape-inside code (Closed)

Created:
6 years, 8 months ago by rwlbuis

Modified:
6 years, 8 months ago

Reviewers:
leviw_travelin_and_unemployed, Bem Jones-Bey (adobe), eseidel

CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, leviw+bidiwatch_chromium.org, jchaffraix+rendering, pdr., rune+blink

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

[CSS Shapes] Remove some leftover shape-inside code Remove leftover code from the shape-inside removal. This is a merge of http://trac.webkit.org/changeset/167283 by Bem Jones-Bey <bjonesbe@adobe.com>;. NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171666

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -18 lines)			Patch
M	Source/core/rendering/BidiRun.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/rendering/RenderBlockFlow.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/RenderBlockLineLayout.cpp	View	5 chunks	+5 lines, -15 lines	0 comments	Download
M	Source/platform/text/BidiCharacterRun.h	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

rwlbuis

Oops, my previous comment was for another patch, ignore. Looks like we need platform approval ...

6 years, 8 months ago (2014-04-15 17:59:29 UTC) #3

leviw_travelin_and_unemployed

The CQ bit was checked by leviw@chromium.org

6 years, 8 months ago (2014-04-15 18:11:58 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/239153004/1

6 years, 8 months ago (2014-04-15 18:12:20 UTC) #6

Message was sent while issue was closed.

Change committed as 171666

Expand Messages | Collapse Messages