Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Issue 2391493002: Prune createVisibleSelectionDeprecated from SelectionController (Closed)

Created:
4 years, 2 months ago by Xiaocheng
Modified:
4 years, 2 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prune createVisibleSelectionDeprecated from SelectionController BUG=651373 Committed: https://crrev.com/4568b4cad0a4e6456bc606a6e813cff95951fd63 Cr-Commit-Position: refs/heads/master@{#422404}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Simplify a call site of createVisibleSelection #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -13 lines) Patch
M third_party/WebKit/Source/core/editing/SelectionController.cpp View 1 9 chunks +11 lines, -13 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
Xiaocheng
PTAL.
4 years, 2 months ago (2016-10-03 06:47:45 UTC) #4
yosin_UTC9
lgtm https://codereview.chromium.org/2391493002/diff/1/third_party/WebKit/Source/core/editing/SelectionController.cpp File third_party/WebKit/Source/core/editing/SelectionController.cpp (right): https://codereview.chromium.org/2391493002/diff/1/third_party/WebKit/Source/core/editing/SelectionController.cpp#newcode162 third_party/WebKit/Source/core/editing/SelectionController.cpp:162: innerNode, createVisibleSelection(createVisiblePosition(pos)))); FYI: We can convert createVisibleSelection(createVisiblePosition(pos)) to ...
4 years, 2 months ago (2016-10-03 07:20:33 UTC) #5
Xiaocheng
https://codereview.chromium.org/2391493002/diff/1/third_party/WebKit/Source/core/editing/SelectionController.cpp File third_party/WebKit/Source/core/editing/SelectionController.cpp (right): https://codereview.chromium.org/2391493002/diff/1/third_party/WebKit/Source/core/editing/SelectionController.cpp#newcode162 third_party/WebKit/Source/core/editing/SelectionController.cpp:162: innerNode, createVisibleSelection(createVisiblePosition(pos)))); On 2016/10/03 at 07:20:33, Yosi_UTC9 wrote: > ...
4 years, 2 months ago (2016-10-03 07:25:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2391493002/20001
4 years, 2 months ago (2016-10-03 12:21:21 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-03 12:25:58 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 12:27:21 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4568b4cad0a4e6456bc606a6e813cff95951fd63
Cr-Commit-Position: refs/heads/master@{#422404}

Powered by Google App Engine
This is Rietveld 408576698