Prune createVisibleSelectionDeprecated from SelectionController

Prune createVisibleSelectionDeprecated from SelectionController

BUG=651373
Committed: https://crrev.com/4568b4cad0a4e6456bc606a6e813cff95951fd63
Cr-Commit-Position: refs/heads/master@{#422404}

[Xiaocheng, 2016-10-03 05:46:14]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-03 05:46:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-10-03 06:47:44]

xiaochengh@chromium.org changed reviewers:
+ yosin@chromium.org

[Xiaocheng, 2016-10-03 06:47:45]

PTAL.

[yosin_UTC9, 2016-10-03 07:20:33]

lgtm

https://codereview.chromium.org/2391493002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/SelectionController.cpp (right):

https://codereview.chromium.org/2391493002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/SelectionController.cpp:162: innerNode,
createVisibleSelection(createVisiblePosition(pos))));
FYI: We can convert createVisibleSelection(createVisiblePosition(pos)) to
createVisibleSelection(pos), since VisualSelection::validate() calls
VisiblePositon ctor.

[Xiaocheng, 2016-10-03 07:25:18]

https://codereview.chromium.org/2391493002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/SelectionController.cpp (right):

https://codereview.chromium.org/2391493002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/SelectionController.cpp:162: innerNode,
createVisibleSelection(createVisiblePosition(pos))));
On 2016/10/03 at 07:20:33, Yosi_UTC9 wrote:
> FYI: We can convert createVisibleSelection(createVisiblePosition(pos)) to
createVisibleSelection(pos), since VisualSelection::validate() calls
VisiblePositon ctor.

Thanks for catching it. I'll update the patch.

[Xiaocheng, 2016-10-03 07:35:12]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-03 07:35:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 10:35:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-03 10:35:55]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2016-10-03 12:21:08]

The CQ bit was checked by xiaochengh@chromium.org

[Xiaocheng, 2016-10-03 12:21:09]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/2391493002/#ps20001
(title: "Simplify a call site of createVisibleSelection")

[commit-bot: I haz the power, 2016-10-03 12:21:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 12:25:58]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-03 12:27:20]

Description was changed from

==========
Prune createVisibleSelectionDeprecated from SelectionController

BUG=651373
==========

to

==========
Prune createVisibleSelectionDeprecated from SelectionController

BUG=651373

Committed: https://crrev.com/4568b4cad0a4e6456bc606a6e813cff95951fd63
Cr-Commit-Position: refs/heads/master@{#422404}
==========

[commit-bot: I haz the power, 2016-10-03 12:27:21]

Patchset 2 (id:??) landed as
https://crrev.com/4568b4cad0a4e6456bc606a6e813cff95951fd63
Cr-Commit-Position: refs/heads/master@{#422404}