Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Issue 2391453002: Remove stl_util's deletion functions from net/proxy/. (Closed)

Created:
4 years, 2 months ago by Avi (use Gerrit)
Modified:
4 years, 2 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove stl_util's deletion functions from net/proxy/. BUG=555865 Committed: https://crrev.com/ca04a62532216b3f1d438825641dae9146462537 Cr-Commit-Position: refs/heads/master@{#423760}

Patch Set 1 #

Patch Set 2 : chromeos #

Patch Set 3 : very chromeos #

Patch Set 4 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -57 lines) Patch
M chrome/browser/chromeos/proxy_cros_settings_parser.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M chromeos/network/onc/onc_utils.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/mojo_proxy_resolver_factory_impl.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M net/proxy/mojo_proxy_resolver_factory_impl.cc View 1 2 3 3 chunks +7 lines, -7 lines 0 comments Download
M net/proxy/mojo_proxy_resolver_impl.h View 1 2 3 2 chunks +1 line, -2 lines 0 comments Download
M net/proxy/mojo_proxy_resolver_impl.cc View 1 2 3 2 chunks +8 lines, -9 lines 0 comments Download
M net/proxy/proxy_bypass_rules.h View 4 chunks +5 lines, -4 lines 0 comments Download
M net/proxy/proxy_bypass_rules.cc View 1 2 3 7 chunks +16 lines, -18 lines 0 comments Download
M net/proxy/proxy_config_service_win.h View 3 chunks +2 lines, -2 lines 0 comments Download
M net/proxy/proxy_config_service_win.cc View 1 2 3 4 chunks +11 lines, -9 lines 0 comments Download

Messages

Total messages: 26 (19 generated)
Avi (use Gerrit)
armansito@chromium.org: Please review changes in chromeos/ satorux@chromium.org: Please review changes in chrome/browser/chromeos davidben@chromium.org: Please review ...
4 years, 2 months ago (2016-10-05 16:45:59 UTC) #18
davidben
net lgtm
4 years, 2 months ago (2016-10-05 20:58:00 UTC) #19
armansito
lgtm
4 years, 2 months ago (2016-10-06 18:56:53 UTC) #20
satorux1
chromeos lgtm
4 years, 2 months ago (2016-10-06 23:00:57 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2391453002/60001
4 years, 2 months ago (2016-10-06 23:08:59 UTC) #23
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 2 months ago (2016-10-07 00:29:10 UTC) #24
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 00:32:25 UTC) #26
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/ca04a62532216b3f1d438825641dae9146462537
Cr-Commit-Position: refs/heads/master@{#423760}

Powered by Google App Engine
This is Rietveld 408576698