Add UMA for PurgeAndSuspend.

Add UMA for PurgeAndSuspend.

- Report memory usage after purging cached memory of a backgrounded renderer.
- intent-to-implement-and-ship of background renderer's purge + suspend is
 https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/DK189tnM8l4
- one of the documents attached in the above intent is
 https://docs.google.com/document/d/1EgLimgxWK5DGhptnNVbEGSvVn6Q609ZJaBkLjEPRJvI/edit?usp=sharing
- The feature is not enabled by default because purge-and-suspend-time is 0.

BUG=635419
Committed: https://crrev.com/b46626af32c274cbb8f0eaad63237e7d339c0a7b
Cr-Commit-Position: refs/heads/master@{#425894}

[tasak, 2016-10-06 04:59:47]

The CQ bit was checked by tasak@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 05:00:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tasak, 2016-10-06 05:02:02]

tasak@google.com changed reviewers:
+ bashi@chromium.org, haraken@chromium.org, isherman@chromium.org,
primiano@chromium.org, skyostil@chromium.org

[tasak, 2016-10-06 05:02:02]

Would you review this CL?

I copied metrics code from https://codereview.chromium.org/2350423003 and
modified to use CancelableCallback.

[haraken, 2016-10-06 08:03:17]

Mostly looks good, but primiano@ should definitely take a look.

https://codereview.chromium.org/2391423004/diff/1/content/renderer/render_thr...
File content/renderer/render_thread_impl.cc (right):

https://codereview.chromium.org/2391423004/diff/1/content/renderer/render_thr...
content/renderer/render_thread_impl.cc:1854: // TODO(tasak): Use memory-infra
when tracing v2 is enabled.

Tracing v2 is not that related. Just say "We should collect the metrics using
memory-infra".

https://codereview.chromium.org/2391423004/diff/1/content/renderer/render_thr...
content/renderer/render_thread_impl.cc:1856: // purging memory when tracing v2
is enabled.

Report a difference between the memory usages before and after purging.

https://codereview.chromium.org/2391423004/diff/1/content/renderer/render_thr...
content/renderer/render_thread_impl.cc:1864: // metrics which measures how many
memory usages are reduced.

TODO: Compare memory metrics between purge-enabled renderers and purge-disabled
renderers (A/B testing).

https://codereview.chromium.org/2391423004/diff/1/content/renderer/render_thr...
content/renderer/render_thread_impl.cc:1897: // all isolates' memory usages.

TODO: Currently only memory usage of mainThreadIsolate() is reported. We should
collect memory usages of all isolates using memory-infra.

https://codereview.chromium.org/2391423004/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/web/WebMemoryStatistics.cpp (right):

https://codereview.chromium.org/2391423004/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/web/WebMemoryStatistics.cpp:30: void
LightPartitionStatsDumperImpl::partitionDumpTotals(

Nit: Inline this method into the class.

https://codereview.chromium.org/2391423004/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2391423004/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:25191: +    suspending a backgrounded
renderer. Note: this metrics is for A/B testing.

The memory usage of the BlinkGC allocator after a background renderer is purged
and suspended. Note: this metric is for A/B testing.

https://codereview.chromium.org/2391423004/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:25199: +    suspending the renderer.
Note: this metrics is for A/B testing.

The memory usage of the discardable memory after a background renderer is purged
and suspended.

https://codereview.chromium.org/2391423004/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:25207: +    suspending the renderer.
Note: this metrics is for A/B testing.

Ditto.

[tasak, 2016-10-06 08:31:10]

Description was changed from

==========
Add UMA for PurgeAndSuspend.

Report memory usage after purging cached memory of a backgrounded renderer.

PurgeAndSuspend design doc is:
https://docs.google.com/document/d/1EgLimgxWK5DGhptnNVbEGSvVn6Q609ZJaBkLjEPRJ...

BUG=635419
==========

to

==========
Add UMA for PurgeAndSuspend.

- Report memory usage after purging cached memory of a backgrounded renderer.
- intent-to-implement-and-ship of background renderer's purge + suspend is
 https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/DK189tnM8l4
- one of the documents attached in the above intent is

https://docs.google.com/document/d/1EgLimgxWK5DGhptnNVbEGSvVn6Q609ZJaBkLjEPRJ...
- The feature is not enabled by default because purge-and-suspend-time is 0.

BUG=635419
==========

[commit-bot: I haz the power, 2016-10-06 08:45:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 08:45:15]

Dry run: This issue passed the CQ dry run.

[tasak, 2016-10-06 09:27:52]

The CQ bit was checked by tasak@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 09:28:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tasak, 2016-10-06 09:30:03]

The CQ bit was checked by tasak@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 09:30:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tasak, 2016-10-06 09:37:49]

The CQ bit was checked by tasak@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 09:37:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tasak, 2016-10-06 09:38:14]

Patchset #2 (id:20001) has been deleted

[tasak, 2016-10-06 09:46:38]

The CQ bit was checked by tasak@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 09:46:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tasak, 2016-10-06 09:47:15]

Patchset #2 (id:40001) has been deleted

[tasak, 2016-10-06 09:47:40]

Thank you for review.

https://codereview.chromium.org/2391423004/diff/1/content/renderer/render_thr...
File content/renderer/render_thread_impl.cc (right):

https://codereview.chromium.org/2391423004/diff/1/content/renderer/render_thr...
content/renderer/render_thread_impl.cc:1854: // TODO(tasak): Use memory-infra
when tracing v2 is enabled.
On 2016/10/06 08:03:16, haraken wrote:
> 
> Tracing v2 is not that related. Just say "We should collect the metrics using
> memory-infra".

Done.

https://codereview.chromium.org/2391423004/diff/1/content/renderer/render_thr...
content/renderer/render_thread_impl.cc:1856: // purging memory when tracing v2
is enabled.
On 2016/10/06 08:03:17, haraken wrote:
> 
> Report a difference between the memory usages before and after purging.

Done.

https://codereview.chromium.org/2391423004/diff/1/content/renderer/render_thr...
content/renderer/render_thread_impl.cc:1864: // metrics which measures how many
memory usages are reduced.
On 2016/10/06 08:03:17, haraken wrote:
> 
> TODO: Compare memory metrics between purge-enabled renderers and
purge-disabled
> renderers (A/B testing).

Done.

https://codereview.chromium.org/2391423004/diff/1/content/renderer/render_thr...
content/renderer/render_thread_impl.cc:1897: // all isolates' memory usages.
On 2016/10/06 08:03:16, haraken wrote:
> 
> TODO: Currently only memory usage of mainThreadIsolate() is reported. We
should
> collect memory usages of all isolates using memory-infra.

Done.

https://codereview.chromium.org/2391423004/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/web/WebMemoryStatistics.cpp (right):

https://codereview.chromium.org/2391423004/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/web/WebMemoryStatistics.cpp:30: void
LightPartitionStatsDumperImpl::partitionDumpTotals(
On 2016/10/06 08:03:17, haraken wrote:
> 
> Nit: Inline this method into the class.

Done.

https://codereview.chromium.org/2391423004/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2391423004/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:25191: +    suspending a backgrounded
renderer. Note: this metrics is for A/B testing.
On 2016/10/06 08:03:17, haraken wrote:
> 
> The memory usage of the BlinkGC allocator after a background renderer is
purged
> and suspended. Note: this metric is for A/B testing.

Done.

https://codereview.chromium.org/2391423004/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:25199: +    suspending the renderer.
Note: this metrics is for A/B testing.
On 2016/10/06 08:03:17, haraken wrote:
> 
> The memory usage of the discardable memory after a background renderer is
purged
> and suspended.

Done.

https://codereview.chromium.org/2391423004/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:25207: +    suspending the renderer.
Note: this metrics is for A/B testing.
On 2016/10/06 08:03:17, haraken wrote:
> 
> Ditto.

Done.

[commit-bot: I haz the power, 2016-10-06 11:08:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 11:08:26]

Dry run: This issue passed the CQ dry run.

[Primiano Tucci (use gerrit), 2016-10-07 16:30:00]

If you really need a short term solution, I don't see many other options other
then doing this. so I have only minimal comments here (and not an owner in any
of these folders).

UMA-ifying memory-infra is definitely on track on our OKRs but I don't have a
valid solution for that *today* unfortunately.
May the force be with you :)

https://codereview.chromium.org/2391423004/diff/60001/content/renderer/render...
File content/renderer/render_thread_impl.cc (right):

https://codereview.chromium.org/2391423004/diff/60001/content/renderer/render...
content/renderer/render_thread_impl.cc:1801: class ScopedHeapLock {
Looks like you are creating this ScopedHeapLock class to just used it in one
place.
Shouldn't you just do this inline in the for-loop of GetMallocUsage below?

https://codereview.chromium.org/2391423004/diff/60001/content/renderer/render...
content/renderer/render_thread_impl.cc:1903: malloc_usage + v8_usage +
discardable_usage);
I think at this point would be also interesting to get the resident set size
from base::ProcessMetrics (GetWorkingSetSize IIRC) to se the final effect on the
OS

[Ilya Sherman, 2016-10-11 00:58:24]

https://codereview.chromium.org/2391423004/diff/60001/content/renderer/render...
File content/renderer/render_thread_impl.cc (right):

https://codereview.chromium.org/2391423004/diff/60001/content/renderer/render...
content/renderer/render_thread_impl.cc:1866:
UMA_HISTOGRAM_MEMORY_KB("Memory.PurgeAndSuspend.PartitionAllocKB",
Note that the range of UMA_HISTOGRAM_MEMORY_KB goes up to 500M.  Is that
sufficient for your needs?

https://codereview.chromium.org/2391423004/diff/60001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2391423004/diff/60001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:25234: +</histogram>
Could you use a histogram_suffixes element to reduce the amount of repetition
involved in documenting these histograms?

[tasak, 2016-10-11 06:39:36]

The CQ bit was checked by tasak@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-11 06:39:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tasak, 2016-10-11 07:55:06]

The CQ bit was checked by tasak@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-11 07:55:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tasak, 2016-10-11 08:10:43]

Patchset #4 (id:100001) has been deleted

[tasak, 2016-10-11 08:10:53]

The CQ bit was checked by tasak@google.com to run a CQ dry run

[tasak, 2016-10-11 08:11:02]

Patchset #3 (id:80001) has been deleted

[commit-bot: I haz the power, 2016-10-11 08:11:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tasak, 2016-10-11 08:15:10]

Thank you for review.

https://codereview.chromium.org/2391423004/diff/60001/content/renderer/render...
File content/renderer/render_thread_impl.cc (right):

https://codereview.chromium.org/2391423004/diff/60001/content/renderer/render...
content/renderer/render_thread_impl.cc:1801: class ScopedHeapLock {
On 2016/10/07 16:30:00, Primiano Tucci - slow til 10th wrote:
> Looks like you are creating this ScopedHeapLock class to just used it in one
> place.
> Shouldn't you just do this inline in the for-loop of GetMallocUsage below?

Done.

https://codereview.chromium.org/2391423004/diff/60001/content/renderer/render...
content/renderer/render_thread_impl.cc:1866:
UMA_HISTOGRAM_MEMORY_KB("Memory.PurgeAndSuspend.PartitionAllocKB",
On 2016/10/11 00:58:23, Ilya Sherman wrote:
> Note that the range of UMA_HISTOGRAM_MEMORY_KB goes up to 500M.  Is that
> sufficient for your needs?

I see.
I changed V8, Malloc and Total to use MB instead of KB.

https://codereview.chromium.org/2391423004/diff/60001/content/renderer/render...
content/renderer/render_thread_impl.cc:1903: malloc_usage + v8_usage +
discardable_usage);
On 2016/10/07 16:30:00, Primiano Tucci - slow til 10th wrote:
> I think at this point would be also interesting to get the resident set size
> from base::ProcessMetrics (GetWorkingSetSize IIRC) to se the final effect on
the
> OS

I agree with you. I would like to monitor resident_set_bytes.
So I would like to add ProcessMetrics-based UMA to MemoryCoordinator (or
TabManager).
Because it is difficult to use ProcessMetrics here in Linux Chrome because of
sandbox.

https://codereview.chromium.org/2391423004/diff/60001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2391423004/diff/60001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:25234: +</histogram>
On 2016/10/11 00:58:23, Ilya Sherman wrote:
> Could you use a histogram_suffixes element to reduce the amount of repetition
> involved in documenting these histograms?

I see.
Done.

[commit-bot: I haz the power, 2016-10-11 10:10:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 10:10:15]

Dry run: This issue passed the CQ dry run.

[Ilya Sherman, 2016-10-11 21:28:57]

https://codereview.chromium.org/2391423004/diff/120001/content/renderer/rende...
File content/renderer/render_thread_impl.cc (right):

https://codereview.chromium.org/2391423004/diff/120001/content/renderer/rende...
content/renderer/render_thread_impl.cc:1848: : "Disabled";
You shouldn't need to add these suffixes manually.  The variations ("Finch")
dashboard should show you the A/B test comparisons directly.

https://codereview.chromium.org/2391423004/diff/120001/tools/metrics/histogra...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2391423004/diff/120001/tools/metrics/histogra...
tools/metrics/histograms/histograms.xml:25422: +    purged and suspended. Note:
this metrics is for A/B testing.
nit: s/metrics/metric (ditto for the other entries)

https://codereview.chromium.org/2391423004/diff/120001/tools/metrics/histogra...
tools/metrics/histograms/histograms.xml:108361: +  <suffix name="Disabled"/>
I'm not sure what these are for.  Are these for the Finch study?  If so, they're
not needed -- that'll be available automatically on the dashboard.

When I suggested a histogram_suffixes element previously, I was thinking that
you could have a single <histogram> entry for "Memory.PurgeAndSuspend", and list
"DiscardableKB", "MallocKB", etc. as the suffixes.  But, now that you're using
KB in some places and MB in others, this probably doesn't make as much sense.

[tasak, 2016-10-12 07:34:27]

The CQ bit was checked by tasak@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-12 07:34:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tasak, 2016-10-12 07:37:23]

Thank you for review.

https://codereview.chromium.org/2391423004/diff/120001/content/renderer/rende...
File content/renderer/render_thread_impl.cc (right):

https://codereview.chromium.org/2391423004/diff/120001/content/renderer/rende...
content/renderer/render_thread_impl.cc:1848: : "Disabled";
On 2016/10/11 21:28:56, Ilya Sherman wrote:
> You shouldn't need to add these suffixes manually.  The variations ("Finch")
> dashboard should show you the A/B test comparisons directly.

I see.
Done.

https://codereview.chromium.org/2391423004/diff/120001/content/renderer/rende...
content/renderer/render_thread_impl.cc:1854:
blink_stats.partitionAllocTotalAllocatedBytes);
I missed "/1024".

https://codereview.chromium.org/2391423004/diff/120001/content/renderer/rende...
content/renderer/render_thread_impl.cc:1870: malloc_usage);
I missed "/1024/1024".

https://codereview.chromium.org/2391423004/diff/120001/tools/metrics/histogra...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2391423004/diff/120001/tools/metrics/histogra...
tools/metrics/histograms/histograms.xml:25422: +    purged and suspended. Note:
this metrics is for A/B testing.
On 2016/10/11 21:28:56, Ilya Sherman wrote:
> nit: s/metrics/metric (ditto for the other entries)

Done.

https://codereview.chromium.org/2391423004/diff/120001/tools/metrics/histogra...
tools/metrics/histograms/histograms.xml:108361: +  <suffix name="Disabled"/>
On 2016/10/11 21:28:56, Ilya Sherman wrote:
> I'm not sure what these are for.  Are these for the Finch study?  If so,
they're
> not needed -- that'll be available automatically on the dashboard.

Yes. For the Finch study.

> When I suggested a histogram_suffixes element previously, I was thinking that
> you could have a single <histogram> entry for "Memory.PurgeAndSuspend", and
list
> "DiscardableKB", "MallocKB", etc. as the suffixes.  But, now that you're using
> KB in some places and MB in others, this probably doesn't make as much sense.

I see. I misunderstood... 
Done.

[commit-bot: I haz the power, 2016-10-12 07:43:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 07:43:18]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[Ilya Sherman, 2016-10-13 00:43:03]

https://codereview.chromium.org/2391423004/diff/140001/tools/metrics/histogra...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2391423004/diff/140001/tools/metrics/histogra...
tools/metrics/histograms/histograms.xml:108434: +</histogram_suffixes>
Since the histograms now use a mix of units, I don't think it's as appropriate
to use histogram_suffixes now.  It's better for each histogram to have the
appropriate units attribute listed in this file.

[tasak, 2016-10-13 03:52:39]

The CQ bit was checked by tasak@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 03:52:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tasak, 2016-10-13 03:56:16]

https://codereview.chromium.org/2391423004/diff/140001/tools/metrics/histogra...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2391423004/diff/140001/tools/metrics/histogra...
tools/metrics/histograms/histograms.xml:108434: +</histogram_suffixes>
On 2016/10/13 00:43:03, Ilya Sherman wrote:
> Since the histograms now use a mix of units, I don't think it's as appropriate
> to use histogram_suffixes now.  It's better for each histogram to have the
> appropriate units attribute listed in this file.

I see.
Thank you.
Done.

[commit-bot: I haz the power, 2016-10-13 05:27:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 05:28:00]

Dry run: This issue passed the CQ dry run.

[tasak, 2016-10-13 08:33:52]

The CQ bit was checked by tasak@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 08:34:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 09:51:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 09:51:24]

Dry run: This issue passed the CQ dry run.

[Ilya Sherman, 2016-10-13 21:55:47]

metrics changes lgtm, thanks

[haraken, 2016-10-14 00:46:55]

LGTM

[tasak, 2016-10-14 09:19:53]

The CQ bit was checked by tasak@google.com

[commit-bot: I haz the power, 2016-10-14 09:20:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 09:29:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-14 09:29:22]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[tasak, 2016-10-17 02:36:11]

tasak@google.com changed reviewers:
+ avi@chromium.org

[tasak, 2016-10-17 02:36:11]

avi, would you review this CL?

I need content/ OWNER's lgtm.

[Avi (use Gerrit), 2016-10-17 02:48:04]

Random nits, but otherwise LGTM.

https://codereview.chromium.org/2391423004/diff/180001/content/renderer/rende...
File content/renderer/render_thread_impl.cc (right):

https://codereview.chromium.org/2391423004/diff/180001/content/renderer/rende...
content/renderer/render_thread_impl.cc:1788: // Since purging is not a
synchronouse task (e.g. v8 GC, oilpan GC, ...),
typo: synchronous

https://codereview.chromium.org/2391423004/diff/180001/content/renderer/rende...
content/renderer/render_thread_impl.cc:1811: for (unsigned i = 0; i <
number_of_heaps; i++) {
for (HANDLE heap : *heaps) ?

[tasak, 2016-10-17 04:53:24]

The CQ bit was checked by tasak@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-17 04:53:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tasak, 2016-10-17 04:54:19]

Thank you for review.

https://codereview.chromium.org/2391423004/diff/180001/content/renderer/rende...
File content/renderer/render_thread_impl.cc (right):

https://codereview.chromium.org/2391423004/diff/180001/content/renderer/rende...
content/renderer/render_thread_impl.cc:1788: // Since purging is not a
synchronouse task (e.g. v8 GC, oilpan GC, ...),
On 2016/10/17 02:48:04, Avi wrote:
> typo: synchronous

Done.

https://codereview.chromium.org/2391423004/diff/180001/content/renderer/rende...
content/renderer/render_thread_impl.cc:1811: for (unsigned i = 0; i <
number_of_heaps; i++) {
On 2016/10/17 02:48:04, Avi wrote:
> for (HANDLE heap : *heaps) ?

Done.

[commit-bot: I haz the power, 2016-10-17 05:38:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-17 05:38:16]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[tasak, 2016-10-17 05:44:07]

Patchset #7 (id:200001) has been deleted

[tasak, 2016-10-17 05:44:16]

The CQ bit was checked by tasak@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-17 05:44:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-17 06:29:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-17 06:29:42]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tasak, 2016-10-17 10:36:10]

Patchset #8 (id:240001) has been deleted

[tasak, 2016-10-17 10:40:23]

https://codereview.chromium.org/2391423004/diff/180001/content/renderer/rende...
File content/renderer/render_thread_impl.cc (right):

https://codereview.chromium.org/2391423004/diff/180001/content/renderer/rende...
content/renderer/render_thread_impl.cc:1811: for (unsigned i = 0; i <
number_of_heaps; i++) {
On 2016/10/17 04:54:19, tasak wrote:
> On 2016/10/17 02:48:04, Avi wrote:
> > for (HANDLE heap : *heaps) ?
> 
> Done.

I found that it is not possible to use this here because number_of_heaps is not
constant.
I saw C3312 error: no callable begin()/end() function.

[tasak, 2016-10-17 10:40:29]

The CQ bit was checked by tasak@google.com

[tasak, 2016-10-17 10:40:30]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org,
haraken@chromium.org, isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/2391423004/#ps260001
(title: "Patch for landing")

[commit-bot: I haz the power, 2016-10-17 10:40:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-17 10:50:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-17 10:50:40]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[tasak, 2016-10-18 02:41:25]

The CQ bit was checked by tasak@google.com

[tasak, 2016-10-18 02:41:26]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org,
haraken@chromium.org, isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/2391423004/#ps280001
(title: "Fixed histograms.xml.")

[commit-bot: I haz the power, 2016-10-18 02:41:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 05:55:10]

Description was changed from

==========
Add UMA for PurgeAndSuspend.

- Report memory usage after purging cached memory of a backgrounded renderer.
- intent-to-implement-and-ship of background renderer's purge + suspend is
 https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/DK189tnM8l4
- one of the documents attached in the above intent is

https://docs.google.com/document/d/1EgLimgxWK5DGhptnNVbEGSvVn6Q609ZJaBkLjEPRJ...
- The feature is not enabled by default because purge-and-suspend-time is 0.

BUG=635419
==========

to

==========
Add UMA for PurgeAndSuspend.

- Report memory usage after purging cached memory of a backgrounded renderer.
- intent-to-implement-and-ship of background renderer's purge + suspend is
 https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/DK189tnM8l4
- one of the documents attached in the above intent is

https://docs.google.com/document/d/1EgLimgxWK5DGhptnNVbEGSvVn6Q609ZJaBkLjEPRJ...
- The feature is not enabled by default because purge-and-suspend-time is 0.

BUG=635419
==========

[commit-bot: I haz the power, 2016-10-18 05:55:11]

Committed patchset #9 (id:280001)

[commit-bot: I haz the power, 2016-10-18 05:58:13]

Description was changed from

==========
Add UMA for PurgeAndSuspend.

- Report memory usage after purging cached memory of a backgrounded renderer.
- intent-to-implement-and-ship of background renderer's purge + suspend is
 https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/DK189tnM8l4
- one of the documents attached in the above intent is

https://docs.google.com/document/d/1EgLimgxWK5DGhptnNVbEGSvVn6Q609ZJaBkLjEPRJ...
- The feature is not enabled by default because purge-and-suspend-time is 0.

BUG=635419
==========

to

==========
Add UMA for PurgeAndSuspend.

- Report memory usage after purging cached memory of a backgrounded renderer.
- intent-to-implement-and-ship of background renderer's purge + suspend is
 https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/DK189tnM8l4
- one of the documents attached in the above intent is

https://docs.google.com/document/d/1EgLimgxWK5DGhptnNVbEGSvVn6Q609ZJaBkLjEPRJ...
- The feature is not enabled by default because purge-and-suspend-time is 0.

BUG=635419

Committed: https://crrev.com/b46626af32c274cbb8f0eaad63237e7d339c0a7b
Cr-Commit-Position: refs/heads/master@{#425894}
==========

[commit-bot: I haz the power, 2016-10-18 05:58:15]

Patchset 9 (id:??) landed as
https://crrev.com/b46626af32c274cbb8f0eaad63237e7d339c0a7b
Cr-Commit-Position: refs/heads/master@{#425894}