Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(833)

Issue 2391423003: Switch 'analyzer' to 'package:test' and test_reflective_loader ^0.1.0. (Closed)

Created:
4 years, 2 months ago by scheglov
Modified:
4 years, 2 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Switch 'analyzer' to 'package:test' and test_reflective_loader ^0.1.0. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/175dad4f1562bdc6c14a99638c446095fc1ab7f1

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+793 lines, -637 lines) Patch
M pkg/analyzer/pubspec.yaml View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer/test/cancelable_future_test.dart View 1 chunk +5 lines, -3 lines 0 comments Download
M pkg/analyzer/test/context/declared_variables_test.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/analyzer/test/context/test_all.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/analyzer/test/dart/ast/ast_test.dart View 2 chunks +14 lines, -12 lines 0 comments Download
M pkg/analyzer/test/dart/ast/test_all.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/analyzer/test/dart/ast/visitor_test.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/analyzer/test/dart/element/element_test.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/analyzer/test/dart/element/test_all.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/analyzer/test/dart/test_all.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/analyzer/test/file_system/memory_file_system_test.dart View 1 chunk +9 lines, -10 lines 0 comments Download
M pkg/analyzer/test/file_system/physical_resource_provider_test.dart View 1 chunk +6 lines, -7 lines 0 comments Download
M pkg/analyzer/test/file_system/resource_uri_resolver_test.dart View 1 chunk +4 lines, -5 lines 0 comments Download
M pkg/analyzer/test/file_system/test_all.dart View 2 chunks +3 lines, -5 lines 0 comments Download
M pkg/analyzer/test/generated/all_the_rest_test.dart View 2 chunks +23 lines, -21 lines 0 comments Download
M pkg/analyzer/test/generated/analysis_context_factory.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/bazel_test.dart View 1 chunk +5 lines, -3 lines 0 comments Download
M pkg/analyzer/test/generated/checked_mode_compile_time_error_code_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/compile_time_error_code_test.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/analyzer/test/generated/constant_test.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/analyzer/test/generated/declaration_resolver_test.dart View 2 chunks +6 lines, -4 lines 0 comments Download
M pkg/analyzer/test/generated/element_resolver_test.dart View 2 chunks +5 lines, -3 lines 0 comments Download
M pkg/analyzer/test/generated/engine_test.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/analyzer/test/generated/error_suppression_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/hint_code_test.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/analyzer/test/generated/incremental_resolver_test.dart View 2 chunks +6 lines, -4 lines 0 comments Download
M pkg/analyzer/test/generated/inheritance_manager_test.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/analyzer/test/generated/java_core_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/java_io_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/non_error_resolver_test.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/analyzer/test/generated/non_hint_code_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/package_test.dart View 2 chunks +6 lines, -5 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 1 chunk +8 lines, -6 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 2 chunks +17 lines, -15 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test_case.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/scanner_test.dart View 1 chunk +7 lines, -5 lines 0 comments Download
M pkg/analyzer/test/generated/sdk_test.dart View 2 chunks +5 lines, -3 lines 0 comments Download
M pkg/analyzer/test/generated/simple_resolver_test.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/analyzer/test/generated/source_factory_test.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/analyzer/test/generated/static_type_analyzer_test.dart View 2 chunks +5 lines, -3 lines 0 comments Download
M pkg/analyzer/test/generated/static_type_warning_code_test.dart View 1 chunk +5 lines, -3 lines 0 comments Download
M pkg/analyzer/test/generated/static_warning_code_test.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/analyzer/test/generated/strong_mode_test.dart View 1 chunk +6 lines, -4 lines 0 comments Download
M pkg/analyzer/test/generated/test_all.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/analyzer/test/generated/test_support.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/type_system_test.dart View 1 chunk +9 lines, -7 lines 0 comments Download
M pkg/analyzer/test/generated/utilities_dart_test.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/analyzer/test/generated/utilities_test.dart View 1 chunk +13 lines, -11 lines 0 comments Download
M pkg/analyzer/test/instrumentation/instrumentation_test.dart View 1 chunk +3 lines, -5 lines 0 comments Download
M pkg/analyzer/test/instrumentation/test_all.dart View 1 chunk +3 lines, -4 lines 0 comments Download
M pkg/analyzer/test/parse_compilation_unit_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/resource_utils.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/source/analysis_options_provider_test.dart View 2 chunks +5 lines, -3 lines 0 comments Download
M pkg/analyzer/test/source/config_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/source/embedder_test.dart View 1 chunk +6 lines, -4 lines 0 comments Download
M pkg/analyzer/test/source/error_processor_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/source/package_map_provider_test.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/analyzer/test/source/package_map_resolver_test.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/analyzer/test/source/path_filter_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/source/sdk_ext_test.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/analyzer/test/source/test_all.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/analyzer/test/src/abstract_single_unit.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/context/abstract_context.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/context/builder_test.dart View 2 chunks +5 lines, -3 lines 0 comments Download
M pkg/analyzer/test/src/context/cache_test.dart View 1 chunk +9 lines, -7 lines 0 comments Download
M pkg/analyzer/test/src/context/context_test.dart View 2 chunks +5 lines, -3 lines 0 comments Download
M pkg/analyzer/test/src/context/test_all.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/analyzer/test/src/dart/ast/test_all.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/analyzer/test/src/dart/ast/utilities_test.dart View 2 chunks +8 lines, -6 lines 0 comments Download
M pkg/analyzer/test/src/dart/constant/evaluation_test.dart View 2 chunks +6 lines, -4 lines 0 comments Download
M pkg/analyzer/test/src/dart/constant/test_all.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/analyzer/test/src/dart/constant/utilities_test.dart View 2 chunks +5 lines, -3 lines 0 comments Download
M pkg/analyzer/test/src/dart/constant/value_test.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/dart/element/element_test.dart View 2 chunks +20 lines, -18 lines 0 comments Download
M pkg/analyzer/test/src/dart/element/test_all.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/analyzer/test/src/dart/sdk/sdk_test.dart View 2 chunks +7 lines, -5 lines 0 comments Download
M pkg/analyzer/test/src/dart/sdk/test_all.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/analyzer/test/src/dart/test_all.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/analyzer/test/src/plugin/plugin_config_test.dart View 5 chunks +6 lines, -6 lines 0 comments Download
M pkg/analyzer/test/src/source/source_resource_test.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/source/test_all.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/analyzer/test/src/summary/api_signature_test.dart View 1 chunk +4 lines, -3 lines 0 comments Download
M pkg/analyzer/test/src/summary/bazel_summary_test.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M pkg/analyzer/test/src/summary/flat_buffers_test.dart View 1 chunk +4 lines, -3 lines 0 comments Download
M pkg/analyzer/test/src/summary/in_summary_source_test.dart View 1 chunk +4 lines, -3 lines 0 comments Download
M pkg/analyzer/test/src/summary/linker_test.dart View 1 chunk +4 lines, -3 lines 0 comments Download
M pkg/analyzer/test/src/summary/name_filter_test.dart View 1 chunk +4 lines, -3 lines 0 comments Download
M pkg/analyzer/test/src/summary/package_bundle_reader_test.dart View 1 chunk +5 lines, -4 lines 0 comments Download
M pkg/analyzer/test/src/summary/prelinker_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/analyzer/test/src/summary/pub_summary_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_ast_test.dart View 2 chunks +6 lines, -5 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_common.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/summary/summarize_ast_strong_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/analyzer/test/src/summary/summarize_ast_test.dart View 1 chunk +4 lines, -3 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_common.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/summary/test_all.dart View 3 chunks +3 lines, -5 lines 0 comments Download
M pkg/analyzer/test/src/task/dart_test.dart View 2 chunks +42 lines, -40 lines 0 comments Download
M pkg/analyzer/test/src/task/dart_work_manager_test.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/task/driver_test.dart View 2 chunks +7 lines, -5 lines 0 comments Download
M pkg/analyzer/test/src/task/general_test.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/task/html_test.dart View 1 chunk +6 lines, -4 lines 0 comments Download
M pkg/analyzer/test/src/task/html_work_manager_test.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/task/incremental_element_builder_test.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/task/inputs_test.dart View 1 chunk +15 lines, -13 lines 0 comments Download
M pkg/analyzer/test/src/task/manager_test.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/task/model_test.dart View 2 chunks +8 lines, -6 lines 0 comments Download
M pkg/analyzer/test/src/task/options_test.dart View 2 chunks +7 lines, -5 lines 0 comments Download
M pkg/analyzer/test/src/task/options_work_manager_test.dart View 1 chunk +5 lines, -3 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/checker_test.dart View 5 chunks +49 lines, -38 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/inferred_type_test.dart View 2 chunks +12 lines, -3 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/non_null_checker_test.dart View 6 chunks +117 lines, -108 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/strong_test_helper.dart View 2 chunks +10 lines, -12 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/test_all.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/analyzer/test/src/task/strong_mode_test.dart View 1 chunk +6 lines, -4 lines 0 comments Download
M pkg/analyzer/test/src/task/test_all.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/analyzer/test/src/task/yaml_test.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/test_all.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/analyzer/test/src/util/absolute_path_test.dart View 1 chunk +5 lines, -3 lines 0 comments Download
M pkg/analyzer/test/src/util/asserts_test.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/util/fast_uri_test.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/util/glob_test.dart View 1 chunk +5 lines, -3 lines 0 comments Download
M pkg/analyzer/test/src/util/lru_map_test.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/util/test_all.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/analyzer/test/src/util/yaml_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/stress/for_git_repository.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/test_all.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/analyzer/test/utils.dart View 1 chunk +2 lines, -4 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
scheglov
4 years, 2 months ago (2016-10-06 01:31:29 UTC) #1
kevmoo
DBC: > pub run test 00:49 +11773: All tests passed! That felt AWESOME! :-D
4 years, 2 months ago (2016-10-06 02:39:35 UTC) #3
Paul Berry
In order to avoid breaking the bots, you'll also need to update the toplevel DEPS ...
4 years, 2 months ago (2016-10-06 03:01:03 UTC) #4
Brian Wilkerson
Should all of the invocations of defineReflectiveSuite define a name? Other than that, lgtm.
4 years, 2 months ago (2016-10-06 03:33:54 UTC) #5
scheglov
4 years, 2 months ago (2016-10-06 15:46:42 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
175dad4f1562bdc6c14a99638c446095fc1ab7f1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698