invert Eternal::IsEmpty logic

test/cctest/test-global-handles.cc

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 320 matching lines @@
   CHECK_EQ(0, eternal_handles->NumberOfHandles());
   for (int i = 0; i < kArrayLength; i++) {
     indices[i] = -1;
     HandleScope scope(isolate);
     v8::Local<v8::Object> object = v8::Object::New();
     object->Set(i, v8::Integer::New(i, v8_isolate));
     // Create with internal api
     eternal_handles->Create(
         isolate, *v8::Utils::OpenHandle(*object), &indices[i]);
     // Create with external api
+    CHECK(eternals[i].IsEmpty());
+    eternals[i].Set(v8_isolate, object);
     CHECK(!eternals[i].IsEmpty());
-    eternals[i].Set(v8_isolate, object);
-    CHECK(eternals[i].IsEmpty());
   }
 
   isolate->heap()->CollectAllAvailableGarbage();
 
   for (int i = 0; i < kArrayLength; i++) {
     for (int j = 0; j < 2; j++) {
       HandleScope scope(isolate);
       v8::Local<v8::Value> local;
       if (j == 0) {
         // Test internal api
         local = v8::Utils::ToLocal(eternal_handles->Get(indices[i]));
       } else {
         // Test external api
         local = eternals[i].Get(v8_isolate);
       }
       v8::Local<v8::Object> object = v8::Handle<v8::Object>::Cast(local);
       v8::Local<v8::Value> value = object->Get(i);
       CHECK(value->IsInt32());
       CHECK_EQ(i, value->Int32Value());
     }
   }
 
   CHECK_EQ(2*kArrayLength, eternal_handles->NumberOfHandles());
 
   // Create an eternal via the constructor
   {
     HandleScope scope(isolate);
     v8::Local<v8::Object> object = v8::Object::New();
     v8::Eternal<v8::Object> eternal(v8_isolate, object);
-    CHECK(eternal.IsEmpty());
+    CHECK(!eternal.IsEmpty());
     CHECK(object == eternal.Get(v8_isolate));
   }
 
   CHECK_EQ(2*kArrayLength + 1, eternal_handles->NumberOfHandles());
 }