Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Issue 2391393005: Remove openssl_bio_string. (Closed)

Created:
4 years, 2 months ago by davidben
Modified:
4 years, 2 months ago
Reviewers:
kcc1, kcc2
CC:
chromium-reviews, fuzzing_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove openssl_bio_string. This thing has no consumers, save for a fuzzer which was added about a week ago, at a time when it had no consumers. BUG=none Committed: https://crrev.com/98e99ecd2fb3fbffbe6a622b0f38a3e930a37964 Cr-Commit-Position: refs/heads/master@{#424071}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -214 lines) Patch
M crypto/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
D crypto/openssl_bio_string.h View 1 chunk +0 lines, -29 lines 0 comments Download
D crypto/openssl_bio_string.cc View 1 chunk +0 lines, -77 lines 0 comments Download
D crypto/openssl_bio_string_unittest.cc View 1 chunk +0 lines, -62 lines 0 comments Download
M testing/libfuzzer/fuzzers/BUILD.gn View 1 chunk +0 lines, -11 lines 0 comments Download
D testing/libfuzzer/fuzzers/openssl_bio_string_fuzzer.cc View 1 chunk +0 lines, -32 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
davidben
:-P
4 years, 2 months ago (2016-10-08 00:25:28 UTC) #5
kcc1
lgtm I don't know this code, but deleting any unused code is usually safe. :)
4 years, 2 months ago (2016-10-08 01:17:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2391393005/1
4 years, 2 months ago (2016-10-08 04:27:15 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/277095)
4 years, 2 months ago (2016-10-08 04:35:41 UTC) #13
davidben
On 2016/10/08 04:35:41, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 2 months ago (2016-10-08 04:41:12 UTC) #14
kcc2
lgtm
4 years, 2 months ago (2016-10-08 04:50:26 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2391393005/1
4 years, 2 months ago (2016-10-08 04:50:32 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-08 04:56:13 UTC) #19
commit-bot: I haz the power
4 years, 2 months ago (2016-10-08 04:57:43 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/98e99ecd2fb3fbffbe6a622b0f38a3e930a37964
Cr-Commit-Position: refs/heads/master@{#424071}

Powered by Google App Engine
This is Rietveld 408576698