Update systrace and profile_chrome's default agent behavior

Update systrace and profile_chrome's default agent behavior

Systrace needs to have atrace as the default agent.
profile_chrome needs to have Chrome tracing as the default agent.

BUG=catapult:#2912,catapult:#2781

Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/f7d080135d034437b8ce00208db09b28796490f3

[Zhen Wang, 2016-10-06 19:52:39]

The CQ bit was checked by zhenw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 19:52:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Zhen Wang, 2016-10-06 19:53:42]

zhenw@chromium.org changed reviewers:
+ ccraik@google.com, peter.y.washington@gmail.com, skyostil@chromium.org

[Zhen Wang, 2016-10-06 19:53:43]

ptal

[Zhen Wang, 2016-10-06 19:55:04]

Description was changed from

==========
Update systrace and profile_chrome's default agent behavior

BUG=catapult:#2912,catapult:#2781
==========

to

==========
Update systrace and profile_chrome's default agent behavior

Systrace needs to have atrace as the default agent.
profile_chrome needs to have Chrome tracing as the default agent.

BUG=catapult:#2912,catapult:#2781
==========

[Chris Craik, 2016-10-06 19:56:37]

LGTM

https://codereview.chromium.org/2391383004/diff/1/systrace/profile_chrome/chr...
File systrace/profile_chrome/chrome_tracing_agent.py (right):

https://codereview.chromium.org/2391383004/diff/1/systrace/profile_chrome/chr...
systrace/profile_chrome/chrome_tracing_agent.py:17: DEFAULT_CHROME_CATEGORIES =
'_DEFAULT_CHROME_CATEGORIES'
why is this just a string that refers to its previous variable name? shouldn't
this be a list of categories?

[Zhen Wang, 2016-10-06 19:58:37]

https://codereview.chromium.org/2391383004/diff/1/systrace/profile_chrome/chr...
File systrace/profile_chrome/chrome_tracing_agent.py (right):

https://codereview.chromium.org/2391383004/diff/1/systrace/profile_chrome/chr...
systrace/profile_chrome/chrome_tracing_agent.py:17: DEFAULT_CHROME_CATEGORIES =
'_DEFAULT_CHROME_CATEGORIES'
On 2016/10/06 19:56:37, Chris Craik wrote:
> why is this just a string that refers to its previous variable name? shouldn't
> this be a list of categories?

This is a magic string used by Chrome for Android.

See
https://cs.chromium.org/chromium/src/content/public/android/java/src/org/chro...

[Peter Washington, 2016-10-06 20:04:03]

lgtm

[commit-bot: I haz the power, 2016-10-06 20:11:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 20:11:38]

Dry run: This issue passed the CQ dry run.

[Zhen Wang, 2016-10-06 20:12:55]

The CQ bit was checked by zhenw@chromium.org

[commit-bot: I haz the power, 2016-10-06 20:13:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 20:14:20]

Description was changed from

==========
Update systrace and profile_chrome's default agent behavior

Systrace needs to have atrace as the default agent.
profile_chrome needs to have Chrome tracing as the default agent.

BUG=catapult:#2912,catapult:#2781
==========

to

==========
Update systrace and profile_chrome's default agent behavior

Systrace needs to have atrace as the default agent.
profile_chrome needs to have Chrome tracing as the default agent.

BUG=catapult:#2912,catapult:#2781

Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2016-10-06 20:14:21]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

[Zhen Wang, 2016-10-07 15:13:55]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2401053002/ by zhenw@chromium.org.

The reason for reverting is: Causing Chrome Perf bot to fail.

BUG=653898.