chrome/test/data/extensions/api_test/webstore_inline_install/install_from_fullscreen.html - Issue 2391353003: Prevent inline install on fullscreen windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/webstore_inline_install/install_from_fullscreen.html

Issue 2391353003: Prevent inline install on fullscreen windows. (Closed)

Patch Set: Updating with reviewer commments. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/webstore_inline_installer_browsertest.cc ('K') | « chrome/browser/extensions/webstore_inline_installer_browsertest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/webstore_inline_install/install_from_fullscreen.html

diff --git a/chrome/test/data/extensions/api_test/webstore_inline_install/install_not_supported.html b/chrome/test/data/extensions/api_test/webstore_inline_install/install_from_fullscreen.html

similarity index 94%

copy from chrome/test/data/extensions/api_test/webstore_inline_install/install_not_supported.html

copy to chrome/test/data/extensions/api_test/webstore_inline_install/install_from_fullscreen.html

index df51eba66a2c87dfd0ce2f05df7cd0950aa88fd4..74da2ba98b44fa55d3edfba7499e6daf5fd67867 100644

--- a/chrome/test/data/extensions/api_test/webstore_inline_install/install_not_supported.html

+++ b/chrome/test/data/extensions/api_test/webstore_inline_install/install_from_fullscreen.html

@@ -23,7 +23,7 @@

window.domAutomationController.send(false);

function(error, errorCode) {

- if (error.indexOf('not supported') != -1 &&

+ if (error.indexOf('can not be initiated from fullscreen') != -1 &&

errorCode == 'notPermitted') {

console.log('Ran test, sending response');

window.domAutomationController.send(true);