Prevent inline install on fullscreen windows.

chrome/browser/extensions/webstore_inline_installer_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/webstore_inline_installer.h"
 
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/content_settings/host_content_settings_map_factory.h"
@@ skipping 238 matching lines @@
   ui_test_utils::NavigateToURL(browser(), install_url);
   // The test page opens a popup which is a new |browser| window.
   Browser* popup_browser =
       chrome::FindLastActiveWithProfile(browser()->profile());
   WebContents* popup_contents =
       popup_browser->tab_strip_model()->GetActiveWebContents();
   EXPECT_EQ(base::ASCIIToUTF16("POPUP"), popup_contents->GetTitle());
   RunTest(popup_contents, "runTest");
 }
 
+IN_PROC_BROWSER_TEST_F(WebstoreInlineInstallerTest,
+                       BlockInlineInstallFromFullscreenForBrowser) {

[meacer, 2016/10/10 17:57:33]

nit: Can you add a comment for this test explaining how browser fullscreen is
different from tab fullscreen?

E.g.
// Prevent inline install while in browser fullscreen mode. Browser fullscreen
// is entered by the user by pressing F11.

(and same for the next test case)

[Ackerman, 2016/10/10 19:35:58]

Done.

+  GURL install_url =

[meacer, 2016/10/10 17:57:33]

nit: const GURL install_url =

[Ackerman, 2016/10/10 19:35:58]

Done.

+      GenerateTestServerUrl(kAppDomain, "install_from_fullscreen.html");
+  ui_test_utils::NavigateToURL(browser(), install_url);
+  AutoAcceptInstall();

[meacer, 2016/10/10 17:57:33]

You probably don't need this since the dialog won't open in the first place?

[Devlin, 2016/10/10 18:35:59]

I think I suggested this when Ben was talking to me about it.  I wanted to make
sure that everything *would* succeed if the error wasn't thrown.  Without this
check, there could be a silent test failure where the extension doesn't get
installed, but the reason it doesn't is because we stall at the dialog showing -
when in fact the dialog should never be shown.

It's probably a little superfluous with the error checks in the js, but it makes
me feel a bit better.

[Ackerman, 2016/10/10 19:35:58]

Keeping per Devlin's comments.

[meacer, 2016/10/10 19:44:00]

Okay, sounds good. I guess without it the test would timeout instead of failing.

+
+  // Enter browser fullscreen mode.
+  FullscreenController* controller =
+      browser()->exclusive_access_manager()->fullscreen_controller();
+  controller->ToggleBrowserFullscreenMode();
+
+  RunTest("runTest");
+
+  // Ensure extension is not installed.
+  ExtensionRegistry* registry = ExtensionRegistry::Get(profile());
+  EXPECT_FALSE(registry->GenerateInstalledExtensionsSet()->Contains(
+      "bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb"));
+}
+
+IN_PROC_BROWSER_TEST_F(WebstoreInlineInstallerTest,
+                       BlockInlineInstallFromFullscreenForTab) {
+  GURL install_url =

[meacer, 2016/10/10 17:57:33]

nit: const GURL install_url =

[Ackerman, 2016/10/10 19:35:58]

Done.

+      GenerateTestServerUrl(kAppDomain, "install_from_fullscreen.html");
+  ui_test_utils::NavigateToURL(browser(), install_url);
+  AutoAcceptInstall();

[meacer, 2016/10/10 17:57:33]

Also not needed?

[Ackerman, 2016/10/10 19:35:58]

Same comment as above.

+  WebContents* web_contents =
+      browser()->tab_strip_model()->GetActiveWebContents();
+  FullscreenController* controller =
+      browser()->exclusive_access_manager()->fullscreen_controller();
+
+  // Enter tab fullscreen mode.
+  controller->EnterFullscreenModeForTab(web_contents, install_url);
+
+  RunTest("runTest");
+
+  // Ensure extension is not installed.
+  ExtensionRegistry* registry = ExtensionRegistry::Get(profile());
+  EXPECT_FALSE(registry->GenerateInstalledExtensionsSet()->Contains(
+      "bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb"));
+}
+
 // Ensure that inline-installing a disabled extension simply re-enables it.
 IN_PROC_BROWSER_TEST_F(WebstoreInlineInstallerTest,
                        ReinstallDisabledExtension) {
   // Install an extension via inline install, and confirm it is successful.
   AutoAcceptInstall();
   ui_test_utils::NavigateToURL(
       browser(), GenerateTestServerUrl(kAppDomain, "install.html"));
   RunTest("runTest");
   ExtensionRegistry* registry = ExtensionRegistry::Get(profile());
   ASSERT_TRUE(registry->enabled_extensions().GetByID(kTestExtensionId));
@@ skipping 90 matching lines @@
       browser(), GenerateTestServerUrl(kAppDomain, "both_listeners.html"),
       NEW_FOREGROUND_TAB, ui_test_utils::BROWSER_TEST_WAIT_FOR_NAVIGATION);
   DCHECK_NE(old_tab_index, browser()->tab_strip_model()->active_index());
   browser()->tab_strip_model()->CloseWebContentsAt(old_tab_index,
                                                    TabStripModel::CLOSE_NONE);
   WebstoreInstallerTest::RunTest("runTest");
   EXPECT_TRUE(registry->enabled_extensions().GetByID(kTestExtensionId));
 }
 
 }  // namespace extensions