Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 2391353002: Revert of Updating the SwarmingIsolatedScriptTest to upload chartjson results to the (Closed)

Created:
4 years, 2 months ago by eyaich1
Modified:
4 years, 2 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of Updating the SwarmingIsolatedScriptTest to upload chartjson results to the (patchset #13 id:240001 of https://codereview.chromium.org/2330133002/ ) Reason for revert: Broke the cronet bots https://build.chromium.org/p/chromium.android/waterfall?builder=Android+Cronet+ARM64+Builder&builder=Android+Cronet+ARM64+Builder+%28dbg%29&builder=Android+Cronet+ARMv6+Builder&builder=Android+Cronet+Builder+%28dbg%29&builder=Android+Cronet+Builder+Asan&builder=Android+Cronet+Data+Reduction+Proxy+Builder&builder=Android+Cronet+KitKat+Builder&builder=Android+Cronet+Lollipop+Builder&builder=Android+Cronet+MIPS+Builder&builder=Android+Cronet+Marshmallow+64bit+Builder&builder=Android+Cronet+Marshmallow+64bit+Perf&builder=Android+Cronet+x86+Builder&builder=Android+Cronet+x86+Builder+%28dbg%29&reload=none See crbug.com/653167 Will break up this CL into the refactor of slave utils and run test (which is what I think broke the existing waterfall since it doesn't run through the new code in chromium_tests) Original issue's description: > Updating the SwarmingIsolatedScriptTest to upload chartjson results to the > perf dashboard when present. I am trying to replicate how we currently do > this for perf tests in scripts/slave/runtest.py, but I am not sure how > close I am. I will iterate once this recipe is running on the fyi > waterfall. It *shouldn't* break any existing behavior given that these > code paths will not execute unless chartjson is present in the results. > > BUG=chromium:633253 > > Committed: https://chromium.googlesource.com/chromium/tools/build/+/d068176dade2dfc687b0625dd976b92737956843 TBR=dpranke@chromium.org,kbr@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:633253 Committed: https://chromium.googlesource.com/chromium/tools/build/+/015582fb381e8c6c182d4711ffe3ba6a34ace5b2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+243 lines, -932 lines) Patch
M scripts/slave/recipe_modules/chromium_tests/api.py View 1 chunk +3 lines, -3 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/steps.py View 3 chunks +0 lines, -40 lines 0 comments Download
M scripts/slave/recipe_modules/test_utils/test_api.py View 2 chunks +1 line, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.py View 2 chunks +5 lines, -50 lines 0 comments Download
D scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_disabled.json View 1 chunk +0 lines, -441 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_harness_failure.json View 1 chunk +3 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_missing_shard.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_passed_isolated_script_test.json View 8 chunks +10 lines, -43 lines 0 comments Download
M scripts/slave/runtest.py View 5 chunks +153 lines, -16 lines 0 comments Download
M scripts/slave/slave_utils.py View 3 chunks +0 lines, -176 lines 0 comments Download
M scripts/slave/unittests/runtest_test.py View 3 chunks +67 lines, -0 lines 0 comments Download
M scripts/slave/unittests/slave_utils_test.py View 2 chunks +0 lines, -73 lines 0 comments Download
D scripts/slave/upload_perf_dashboard_results.py View 1 chunk +0 lines, -83 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
eyaich1
Created Revert of Updating the SwarmingIsolatedScriptTest to upload chartjson results to the
4 years, 2 months ago (2016-10-05 18:42:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2391353002/1
4 years, 2 months ago (2016-10-05 18:42:13 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 2 months ago (2016-10-05 18:42:14 UTC) #5
Ken Russell (switch to Gerrit)
lgtm
4 years, 2 months ago (2016-10-05 18:43:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2391353002/1
4 years, 2 months ago (2016-10-05 18:43:13 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/build/+/015582fb381e8c6c182d4711ffe3ba6a34ace5b2
4 years, 2 months ago (2016-10-05 18:43:23 UTC) #10
Dirk Pranke
4 years, 2 months ago (2016-10-05 19:39:58 UTC) #11
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698