No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 2 months ago
(2016-10-05 18:42:14 UTC)
#5
No L-G-T-M from a valid reviewer yet.
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-infra-committers".
Note that this has nothing to do with OWNERS files.
Ken Russell (switch to Gerrit)
lgtm
4 years, 2 months ago
(2016-10-05 18:43:02 UTC)
#6
lgtm
Ken Russell (switch to Gerrit)
The CQ bit was checked by kbr@chromium.org
4 years, 2 months ago
(2016-10-05 18:43:09 UTC)
#7
Description was changed from ========== Revert of Updating the SwarmingIsolatedScriptTest to upload chartjson results to ...
4 years, 2 months ago
(2016-10-05 18:43:22 UTC)
#9
Message was sent while issue was closed.
Description was changed from
==========
Revert of Updating the SwarmingIsolatedScriptTest to upload chartjson results to
the (patchset #13 id:240001 of https://codereview.chromium.org/2330133002/ )
Reason for revert:
Broke the cronet bots
https://build.chromium.org/p/chromium.android/waterfall?builder=Android+Crone...
See crbug.com/653167
Will break up this CL into the refactor of slave utils and run test (which is
what I think broke the existing waterfall since it doesn't run through the new
code in chromium_tests)
Original issue's description:
> Updating the SwarmingIsolatedScriptTest to upload chartjson results to the
> perf dashboard when present. I am trying to replicate how we currently do
> this for perf tests in scripts/slave/runtest.py, but I am not sure how
> close I am. I will iterate once this recipe is running on the fyi
> waterfall. It *shouldn't* break any existing behavior given that these
> code paths will not execute unless chartjson is present in the results.
>
> BUG=chromium:633253
>
> Committed:
https://chromium.googlesource.com/chromium/tools/build/+/d068176dade2dfc687b0...TBR=dpranke@chromium.org,kbr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:633253
==========
to
==========
Revert of Updating the SwarmingIsolatedScriptTest to upload chartjson results to
the (patchset #13 id:240001 of https://codereview.chromium.org/2330133002/ )
Reason for revert:
Broke the cronet bots
https://build.chromium.org/p/chromium.android/waterfall?builder=Android+Crone...
See crbug.com/653167
Will break up this CL into the refactor of slave utils and run test (which is
what I think broke the existing waterfall since it doesn't run through the new
code in chromium_tests)
Original issue's description:
> Updating the SwarmingIsolatedScriptTest to upload chartjson results to the
> perf dashboard when present. I am trying to replicate how we currently do
> this for perf tests in scripts/slave/runtest.py, but I am not sure how
> close I am. I will iterate once this recipe is running on the fyi
> waterfall. It *shouldn't* break any existing behavior given that these
> code paths will not execute unless chartjson is present in the results.
>
> BUG=chromium:633253
>
> Committed:
https://chromium.googlesource.com/chromium/tools/build/+/d068176dade2dfc687b0...TBR=dpranke@chromium.org,kbr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:633253
Committed:
https://chromium.googlesource.com/chromium/tools/build/+/015582fb381e8c6c182d...
==========
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/build/+/015582fb381e8c6c182d4711ffe3ba6a34ace5b2
4 years, 2 months ago
(2016-10-05 18:43:23 UTC)
#10
Issue 2391353002: Revert of Updating the SwarmingIsolatedScriptTest to upload chartjson results to the
(Closed)
Created 4 years, 2 months ago by eyaich1
Modified 4 years, 2 months ago
Reviewers: Dirk Pranke, Ken Russell (switch to Gerrit)
Base URL:
Comments: 0